Skip to content

perf(transformer/module_runner): use itoa to convert u32 to string #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 11, 2025
Merged

perf(transformer/module_runner): use itoa to convert u32 to string #9686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/oxc_transformer/src/plugins/module_runner_transform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
/// another problem: how to transform identifiers which refer to imports? We must collect some information from imports,
/// but it is already at the end of the visitor. To solve this, we may introduce a new visitor to transform identifiers,
/// dynamic imports, and import meta.
use compact_str::ToCompactString;
use itoa::Buffer as ItoaBuffer;
use rustc_hash::FxHashMap;
use std::iter;

Expand Down Expand Up @@ -639,7 +639,8 @@ impl<'a> ModuleRunnerTransform<'a> {

/// Generate a unique import binding name like `__vite_ssr_import_{uid}__`.
fn generate_import_binding_name(&mut self, ctx: &TraverseCtx<'a>) -> Atom<'a> {
let uid_str = &self.import_uid.to_compact_string();
let mut buffer = ItoaBuffer::new();
let uid_str = buffer.format(self.import_uid);
self.import_uid += 1;
ctx.ast.atom_from_strs_array(["__vite_ssr_import_", uid_str, "__"])
}
Expand Down
Loading