Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 20, 2025

This is a hot path for JSX transform, allocating sufficient memory can avoid reserving in push, every bit of optimization that adds up can be huge.

@Dunqing Dunqing requested a review from overlookmotel as a code owner March 20, 2025 06:39
Copy link
Member Author

Dunqing commented Mar 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Instrumentation Performance Report

Merging #9915 will not alter performance

Comparing 03-20-perf_transformer_jsx_pre-allocate_enough_memory_for_arguments_of_createelement_jsx_function (374050a) with main (fbb268a)

Summary

✅ 33 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Mar 20, 2025

image

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cowabunga!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
Copy link
Member

overlookmotel commented Mar 21, 2025

Merge activity

  • Mar 21, 4:43 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 21, 4:43 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 21, 5:11 AM EDT: A user merged this pull request with the Graphite merge queue.

…`createElement`/`jsx` function (#9915)

This is a hot path for JSX transform, allocating sufficient memory can avoid reserving in `push`, every bit of optimization that adds up can be huge.
@graphite-app graphite-app bot force-pushed the 03-20-perf_transformer_jsx_pre-allocate_enough_memory_for_arguments_of_createelement_jsx_function branch from 831c8f2 to 374050a Compare March 21, 2025 08:55
@graphite-app graphite-app bot merged commit 374050a into main Mar 21, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 03-20-perf_transformer_jsx_pre-allocate_enough_memory_for_arguments_of_createelement_jsx_function branch March 21, 2025 09:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants