Skip to content

perf(transformer/jsx): pre-allocate enough memory for arguments of createElement/jsx function #9915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 21, 2025
Merged

perf(transformer/jsx): pre-allocate enough memory for arguments of createElement/jsx function #9915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/oxc_transformer/src/jsx/jsx_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,9 @@ impl<'a> JsxImpl<'a, '_> {
let is_development = self.options.development;
let is_element = opening_element.is_some();

let mut arguments = ctx.ast.vec();
// The maximum capacity length of arguments allowed.
let capacity = if is_classic { 3 + children.len() } else { 6 };
let mut arguments = ctx.ast.vec_with_capacity(capacity);

// The key prop in `<div key={true} />`
let mut key_prop = None;
Expand Down Expand Up @@ -755,6 +757,7 @@ impl<'a> JsxImpl<'a, '_> {
self.get_fragment(ctx)
};
arguments.insert(0, Argument::from(argument_expr));
debug_assert!(arguments.len() <= capacity);

let callee = self.get_create_element(has_key_after_props_spread, need_jsxs, ctx);
ctx.ast.expression_call_with_pure(span, callee, NONE, arguments, false, self.pure)
Expand Down