Skip to content

perf(regular_expression): make all fieldless enums Copy #9937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 21, 2025
Merged

perf(regular_expression): make all fieldless enums Copy #9937

graphite-app merged 1 commit into from
Mar 21, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 21, 2025 •
edited
Loading

Fieldless enums should always be Copy because they're only 1 byte. There is no point in passing them by reference.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Mar 21, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 21, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 21, 2025 05:02
@overlookmotel overlookmotel requested a review from leaysgur as a code owner March 21, 2025 05:02
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 21, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9937 will not alter performance

Comparing 03-21-perf_regular_expression_make_all_fieldless_enums_copy_ (a09bbcf) with main (9a36e67)

Summary

✅ 33 untouched benchmarks

@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 21, 2025

Trivial change, so merging without review.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 21, 2025 •
edited
Loading

Merge activity

@overlookmotel
perf(regular_expression): make all fieldless enums Copy (#9937)
a09bbcf 
Fieldless enums should always be `Copy` because they're only 1 byte. There is no point in passing them by reference.
@graphite-app graphite-app bot force-pushed the 03-21-perf_regular_expression_make_all_fieldless_enums_copy_ branch from ee27e81 to a09bbcf Compare March 21, 2025 05:15
@graphite-app graphite-app bot merged commit a09bbcf into main Mar 21, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
@graphite-app graphite-app bot deleted the 03-21-perf_regular_expression_make_all_fieldless_enums_copy_ branch March 21, 2025 05:22
@oxc-bot oxc-bot mentioned this pull request Mar 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees

No one assigned

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel