refactor(ast_tools): simplify CloneIn derive
#9938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 21, 2025
github-actions
bot
added
A-ast
CodSpeed Instrumentation Performance ReportMerging #9938 will not alter performanceComparing Summary
|
Member
Author
|
Does not make an substantial changes to generated code, only simplifies the code generator, so merging without review. |
Member
Author
Merge activity
|
Simplify implementation of code generator for `CloneIn`. Instead of complicated code to avoid unused vars, just add `#![allow(unused_variables)]` to silence the lint rules. And always use same name for the lifetime. These changes make the logic of the code generator simpler. Also add line breaks to generated code for readability.
graphite-app
bot
force-pushed
the
03-21-perf_regular_expression_make_all_fieldless_enums_copy_
branch
from
ee27e81 to
a09bbcf
Compare
graphite-app
bot
force-pushed
the
03-21-refactor_ast_tools_simplify_clonein_derive
branch
from
410e54c to
28179cd
Compare
Base automatically changed from
03-21-perf_regular_expression_make_all_fieldless_enums_copy_
to
main
March 21, 2025 05:22
graphite-app
bot
deleted the
03-21-refactor_ast_tools_simplify_clonein_derive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify implementation of code generator for
CloneIn.Instead of complicated code to avoid unused vars, just add
#![allow(unused_variables)]to silence the lint rules. And always use same name for the lifetime. These changes make the logic of the code generator simpler.Also add line breaks to generated code for readability.