fix(ast/estree): fix TS type def for TSThisParameter
#9942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 21, 2025
Base automatically changed from
03-18-fix_ast_estree_fix_function.this_param_
to
main
March 21, 2025 07:31
CodSpeed Instrumentation Performance ReportMerging #9942 will not alter performanceComparing Summary
|
Member
Author
|
I think this is fine, so merging. But cc @hi-ogawa for your information. |
Member
Author
Merge activity
|
Follow-on after #9913. `TSThisParameter` is a TS-only type, so its fields aren't optional the way the TS fields of JS types are. Fix the type def by using JS versions of added fields (`False` instead of `TsFalse` etc). Also re-order the fields, so that `name` is first. We want the object shape to be the same (same field order) for all types which are `Identifier`s in the ESTree AST.
graphite-app
bot
force-pushed
the
03-21-fix_ast_estree_fix_ts_type_def_for_tsthisparameter_
branch
from
d587d45 to
9d1035e
Compare
graphite-app
bot
deleted the
03-21-fix_ast_estree_fix_ts_type_def_for_tsthisparameter_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #9913.
TSThisParameteris a TS-only type, so its fields aren't optional the way the TS fields of JS types are.Fix the type def by using JS versions of added fields (
Falseinstead ofTsFalseetc).Also re-order the fields, so that
nameis first. We want the object shape to be the same (same field order) for all types which areIdentifiers in the ESTree AST.