fix(ast/estree): fix Function.this_param
#9913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2025
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #9913 will not alter performanceComparing Summary
|
hi-ogawa
force-pushed
the
03-18-fix_ast_estree_fix_function.this_param_
branch
from
431392e to
7936dae
Compare
overlookmotel
approved these changes
Mar 21, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I think there's a better way than adding SequenceSerializer::serialize_ts_element. I'll make a follow-up PR.
But... test passes % into double figures! Still a long way to go, but we're getting somewhere now...
Member
Merge activity
|
Base automatically changed from
03-20-fix_ast_extree_fix_tsmoduledeclaration.global_
to
graphite-base/9907
March 21, 2025 06:57
overlookmotel
force-pushed
the
03-18-fix_ast_estree_fix_function.this_param_
branch
from
20f19af to
ae3a901
Compare
overlookmotel
changed the base branch from
graphite-base/9913
to
03-21-fix_ast_extree_fix_tsmoduledeclaration.global_
Base automatically changed from
03-21-fix_ast_extree_fix_tsmoduledeclaration.global_
to
main
March 21, 2025 07:18
`Function.this_param` is included in `Function.params` as an `Identifier` with `name: "this"` https://ast-explorer.dev/#eNolykEKwzAMRNGrmFm10F7AB+lKG2MU6uAoJlICwfjuUchiNu9PR0XEnI6keSvN8EFzsLPxA1/WWuT27D7tkq2sEqaX/YvG0Mfb53X12klCIHBe0o839R8hOtRkrEYgGRgXircmAw==
graphite-app
bot
force-pushed
the
03-18-fix_ast_estree_fix_function.this_param_
branch
from
ae3a901 to
8228b74
Compare
This was referenced Mar 21, 2025
graphite-app
bot
deleted the
03-18-fix_ast_estree_fix_function.this_param_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Follow-on after #9913. `TSThisParameter` is a TS-only type, so its fields aren't optional the way the TS fields of JS types are. Fix the type def by using JS versions of added fields (`False` instead of `TsFalse` etc). Also re-order the fields, so that `name` is first. We want the object shape to be the same (same field order) for all types which are `Identifier`s in the ESTree AST.
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
…zer` (#9943) Remove the `serialize_ts_element` method added in #9913, and instead expose an `INCLUDE_TS_FIELDS` constant on `Serializer` trait. Before: ```rs if let Some(this_param) = &self.0.this_param { seq.serialize_ts_element(this_param); } ``` After: ```rs if S::INCLUDE_TS_FIELDS { if let Some(this_param) = &self.0.this_param { seq.serialize_element(this_param); } } ``` This has one slight advantage. Because `INCLUDE_TS_FIELDS` is a constant, compiler will easily be able to prove that the code inside `if S::INCLUDE_TS_FIELDS { ... }` is dead code in the JS-only AST serializer, and remove it. In this specific case, the TS-only logic is trivial, so compiler would probably see it could be optimized out anyway. But we may encounter other cases where more complex TS-only code is required, and compiler might not be able to prove that it's dead code in those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function.this_paramis included inFunction.paramsas anIdentifierwithname: "this"https://ast-explorer.dev/#eNolykEKwzAMRNGrmFm10F7AB+lKG2MU6uAoJlICwfjuUchiNu9PR0XEnI6keSvN8EFzsLPxA1/WWuT27D7tkq2sEqaX/YvG0Mfb53X12klCIHBe0o839R8hOtRkrEYgGRgXircmAw==