Add refaster rule to simplify empty optional asserts

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjOptionalIsNotPresent.java

@@ -0,0 +1,44 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import com.google.errorprone.refaster.ImportPolicy;
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import com.google.errorprone.refaster.annotation.UseImportPolicy;
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public final class AssertjOptionalIsNotPresent<T> {
+
+    @BeforeTemplate
+    void before1(Optional<T> thing) {
+        assertThat(thing.isPresent()).isFalse();
+    }
+
+    @BeforeTemplate
+    void before2(Optional<T> thing) {
+        assertThat(!thing.isPresent()).isTrue();
+    }
+
+    @AfterTemplate
+    @UseImportPolicy(ImportPolicy.STATIC_IMPORT_ALWAYS)
+    void after(Optional<T> thing) {
+        assertThat(thing).isNotPresent();
+    }
+}

baseline-refaster-rules/src/main/java/com/palantir/baseline/refaster/AssertjOptionalIsNotPresentWithDescription.java

@@ -0,0 +1,44 @@
+/*
+ * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.palantir.baseline.refaster;
+
+import com.google.errorprone.refaster.ImportPolicy;
+import com.google.errorprone.refaster.annotation.AfterTemplate;
+import com.google.errorprone.refaster.annotation.BeforeTemplate;
+import com.google.errorprone.refaster.annotation.UseImportPolicy;
+import java.util.Optional;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+public final class AssertjOptionalIsNotPresentWithDescription<T> {
+
+    @BeforeTemplate
+    void before1(Optional<T> thing, String description) {
+        assertThat(thing.isPresent()).describedAs(description).isFalse();
+    }
+
+    @BeforeTemplate
+    void before2(Optional<T> thing, String description) {
+        assertThat(!thing.isPresent()).describedAs(description).isTrue();
+    }
+
+    @AfterTemplate
+    @UseImportPolicy(ImportPolicy.STATIC_IMPORT_ALWAYS)
+    void after(Optional<T> thing, String description) {
+        assertThat(thing).describedAs(description).isNotPresent();
+    }
+}

baseline-refaster-rules/src/test/java/com/palantir/baseline/refaster/AssertjOptionalPresenceTest.java

@@ -65,4 +65,54 @@ public void isPresent_description() {
                         "  }",
                         "}");
     }
+
+    @Test
+    public void isNotPresent_simple() {
+        RefasterTestHelper
+                .forRefactoring(AssertjOptionalIsNotPresent.class)
+                .withInputLines(
+                        "Test",
+                        "import static org.assertj.core.api.Assertions.assertThat;",
+                        "import java.util.Optional;",
+                        "public class Test {",
+                        "  void f(Optional<String> in) {",
+                        "    assertThat(in.isPresent()).isFalse();",
+                        "    assertThat(!in.isPresent()).isTrue();",
+                        "  }",
+                        "}")
+                .hasOutputLines(
+                        "import static org.assertj.core.api.Assertions.assertThat;",
+                        "import java.util.Optional;",
+                        "public class Test {",
+                        "  void f(Optional<String> in) {",
+                        "    assertThat(in).isNotPresent();",
+                        "    assertThat(in).isNotPresent();",
+                        "  }",
+                        "}");
+    }
+
+    @Test
+    public void isNotPresent_description() {
+        RefasterTestHelper
+                .forRefactoring(AssertjOptionalIsNotPresentWithDescription.class)
+                .withInputLines(
+                        "Test",
+                        "import static org.assertj.core.api.Assertions.assertThat;",
+                        "import java.util.Optional;",
+                        "public class Test {",
+                        "  void f(Optional<String> in) {",
+                        "    assertThat(in.isPresent()).describedAs(\"desc\").isFalse();",
+                        "    assertThat(!in.isPresent()).describedAs(\"desc\").isTrue();",
+                        "  }",
+                        "}")
+                .hasOutputLines(
+                        "import static org.assertj.core.api.Assertions.assertThat;",
+                        "import java.util.Optional;",
+                        "public class Test {",
+                        "  void f(Optional<String> in) {",
+                        "    assertThat(in).describedAs(\"desc\").isNotPresent();",
+                        "    assertThat(in).describedAs(\"desc\").isNotPresent();",
+                        "  }",
+                        "}");
+    }
 }