Skip to content

Add refaster rule to simplify empty optional asserts #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 5 commits into from
Sep 30, 2019
Merged

Add refaster rule to simplify empty optional asserts #911

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce3c89b
Add refaster rule to simplify empty optional asserts
Sep 30, 2019
1800da4
Add generated changelog entries
Sep 30, 2019
59bf1ca
fmt
Sep 30, 2019
ac93160
one more case
Sep 30, 2019
fea0172
11
Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
11
  • Loading branch information
Carter Kozak committed Sep 30, 2019
commit fea0172a6c200e3e545f56198ba9bb4d147107c0
8 changes: 8 additions & 0 deletions ...aster-rules/src/test/java/com/palantir/baseline/refaster/AssertjOptionalPresenceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

package com.palantir.baseline.refaster;

import static org.assertj.core.api.Assumptions.assumeThat;

import org.junit.Test;

public class AssertjOptionalPresenceTest {
Expand Down Expand Up @@ -68,6 +70,9 @@ public void isPresent_description() {

@Test
public void isNotPresent_simple() {
assumeThat(System.getProperty("java.specification.version"))
.describedAs("Refaster does not currently support fluent refactors on java 11")
.isEqualTo("1.8");
RefasterTestHelper
.forRefactoring(AssertjOptionalIsNotPresent.class)
.withInputLines(
Expand Down Expand Up @@ -95,6 +100,9 @@ public void isNotPresent_simple() {

@Test
public void isNotPresent_description() {
assumeThat(System.getProperty("java.specification.version"))
.describedAs("Refaster does not currently support fluent refactors on java 11")
.isEqualTo("1.8");
RefasterTestHelper
.forRefactoring(AssertjOptionalIsNotPresentWithDescription.class)
.withInputLines(
Expand Down