Make ByteUnit in HumanReadableByteCount public #297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your interest in palantir/human-readable-types, @arseny-bogomolov! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
carterkozak
approved these changes
Jul 23, 2021
Contributor
carterkozak
left a comment
carterkozak
left a comment
There was a problem hiding this comment.
lgtm. Once you link your account internally the CLA warning will resolve itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
ByteUnitwas package access, and it needs to be public to useSizeFunctionintroduced in #286After this PR
==COMMIT_MSG==
ByteUnitenum is now public, and can be used withSizeFunctionwhen mappingHumanReadableByteCount==COMMIT_MSG==
Possible downsides?