Replace HumanReadableByteCount getSize/getUnit with more obvious map(func)
#286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it obvious that the values must be used together.
Generate changelog in
|
carterkozak
changed the title
getSize/getUnit with more obvious map(func)`getSize/getUnit with more obvious map(func)
jkozlowski
reviewed
Jun 30, 2021
| * | ||
| * @deprecated in favor of {@link #map(SizeFunction)} which is harder to misuse. | ||
| */ | ||
| @DoNotCall |
There was a problem hiding this comment.
Will this fail the build for people? Do we need to write a migration for them?
Contributor
Author
There was a problem hiding this comment.
Yes, but it won’t cause transitive failures. The problem with a migration is that it won’t fix incorrect uses.
schlosna
approved these changes
Jun 30, 2021
Contributor
|
Thanks @carterkozak , this should be more resilient to potential misuse |
Collaborator
|
Released 1.4.0 |
This was referenced Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it obvious that the values must be used together.
==COMMIT_MSG==
Replace HumanReadableByteCount
getSize/getUnitwith more obviousmap(func)==COMMIT_MSG==
Possible downsides?
API churn
Alternatives?