Skip to content

Make ByteUnit in HumanReadableByteCount public #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bulldozer-bot merged 2 commits into from
Jul 23, 2021
Merged

Make ByteUnit in HumanReadableByteCount public #298

bulldozer-bot merged 2 commits into from
Jul 23, 2021

Conversation

@arseny-bogomolov
Copy link
Contributor

@arseny-bogomolov arseny-bogomolov commented Jul 23, 2021

Before this PR

ByteUnit was package access, and it needs to be public to use SizeFunction introduced in #286

After this PR

==COMMIT_MSG==
ByteUnit enum is now public, and can be used with SizeFunction when mapping HumanReadableByteCount
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jul 23, 2021 •
edited by arseny-bogomolov
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

ByteUnit enum is now public, and can be used with SizeFunction when mapping HumanReadableByteCount

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from ferozco July 23, 2021 13:23
carterkozak
carterkozak approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm

@bulldozer-bot bulldozer-bot bot merged commit 70b3621 into develop Jul 23, 2021
@bulldozer-bot bulldozer-bot bot deleted the ab/byte-unit-public branch July 23, 2021 13:29
@svc-autorelease
Copy link
Collaborator

svc-autorelease commented Jul 23, 2021

Released 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferozco ferozco Awaiting requested review from ferozco

1 more reviewer

@carterkozak carterkozak carterkozak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autorelease merge when ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arseny-bogomolov @svc-autorelease @carterkozak @svc-changelog