TST: add fillna test for filling with Categorical #62319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Sep 30, 2025
| ) | ||
|
|
||
| filler = Series(Categorical([10.0, 20.0, 30.0])) | ||
| df.fillna({"ints": filler}, inplace=True) |
There was a problem hiding this comment.
Can you avoid mutating here; when debugging, it can be helpful to have both before and after the operation accessible.
Suggested change
| df.fillna({"ints": filler}, inplace=True) | |
| result = df.fillna({"ints": filler}) |
| tm.assert_frame_equal(df.fillna(value=NaT), df) | ||
|
|
||
| def test_fillna_with_categorical_series(self): | ||
| df = DataFrame( |
There was a problem hiding this comment.
Add a reference to the issue as a comment on the first line.
# https://github.com/pandas-dev/pandas/issues/56329
rhshadrach
added
Missing-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to TestFillNA to check that call fillna with a
Seriesof dtypeCategoricaldoes not throw an error.