chore(deps): bump breaking deps #14570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
previously requested changes
Feb 19, 2025
|
|
||
| # p2p | ||
| discv5 = "0.8.0" | ||
| discv5 = "0.9" |
Collaborator
There was a problem hiding this comment.
Suggested change
| discv5 = "0.9" | |
| discv5 = "0.9.1" |
mattsse
approved these changes
Feb 19, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
updated the failing test
| let (rec, sig) = signature.serialize_compact(); | ||
| sig_bytes.extend_from_slice(&sig); | ||
| sig_bytes.put_u8(rec.to_i32() as u8); | ||
| sig_bytes.put_u8(i32::from(rec) as u8); |
Comment on lines
-738
to
-741
| assert!(matches!( | ||
| event_2_v5, | ||
| discv5::Event::SessionEstablished(node, socket) if node == node_1_enr && socket == node_1_enr.udp4_socket().unwrap().into() | ||
| )); |
Collaborator
There was a problem hiding this comment.
this is an internal discv5 event change so this established event is no longer emitted
mattsse
dismissed
emhane’s stale review
this is 0.9.1 in the lockfile already
loocapro
pushed a commit
to loocapro/reth
that referenced
this pull request
Feb 21, 2025
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secp256k1 breaking change wow didnt see this one coming ever
Blocked on: