-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(deps): bump breaking deps #14570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,7 +122,7 @@ impl Message { | |
| // Serialize the signature and append it to the signature bytes | ||
| let (rec, sig) = signature.serialize_compact(); | ||
| sig_bytes.extend_from_slice(&sig); | ||
| sig_bytes.put_u8(rec.to_i32() as u8); | ||
| sig_bytes.put_u8(i32::from(rec) as u8); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| sig_bytes.unsplit(payload); | ||
|
|
||
| // Calculate the hash of the signature bytes and append it to the datagram | ||
|
|
@@ -156,7 +156,7 @@ impl Message { | |
| } | ||
|
|
||
| let signature = &packet[32..96]; | ||
| let recovery_id = RecoveryId::from_i32(packet[96] as i32)?; | ||
| let recovery_id = RecoveryId::try_from(packet[96] as i32)?; | ||
| let recoverable_sig = RecoverableSignature::from_compact(signature, recovery_id)?; | ||
|
|
||
| // recover the public key | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -655,8 +655,8 @@ pub async fn lookup( | |
| mod test { | ||
| use super::*; | ||
| use ::enr::{CombinedKey, EnrKey}; | ||
| use rand::thread_rng; | ||
| use reth_chainspec::MAINNET; | ||
| use secp256k1::rand::thread_rng; | ||
| use tracing::trace; | ||
|
|
||
| fn discv5_noop() -> Discv5 { | ||
|
|
@@ -729,16 +729,12 @@ mod test { | |
| node_1.with_discv5(|discv5| discv5.send_ping(node_2_enr.clone())).await.unwrap(); | ||
|
|
||
| // verify node_1:discv5 is connected to node_2:discv5 and vv | ||
| let event_2_v5 = stream_2.recv().await.unwrap(); | ||
| let event_1_v5 = stream_1.recv().await.unwrap(); | ||
|
|
||
| assert!(matches!( | ||
| event_1_v5, | ||
| discv5::Event::SessionEstablished(node, socket) if node == node_2_enr && socket == node_2_enr.udp4_socket().unwrap().into() | ||
| )); | ||
| assert!(matches!( | ||
| event_2_v5, | ||
| discv5::Event::SessionEstablished(node, socket) if node == node_1_enr && socket == node_1_enr.udp4_socket().unwrap().into() | ||
| )); | ||
|
Comment on lines
-738
to
-741
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is an internal discv5 event change so this established event is no longer emitted |
||
|
|
||
| // verify node_1 is in KBuckets of node_2:discv5 | ||
| let event_2_v5 = stream_2.recv().await.unwrap(); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.