Add interop hardfork in all relevant places. #14582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 places commented out, because need changes in alloys and revm
mattsse
approved these changes
Feb 19, 2025
| (OpHardfork::Granite.boxed(), genesis_info.granite_time), | ||
| (OpHardfork::Holocene.boxed(), genesis_info.holocene_time), | ||
| (OpHardfork::Isthmus.boxed(), genesis_info.isthmus_time), | ||
| // (OpHardfork::Interop.boxed(), genesis_info.interop_time), |
Collaborator
There was a problem hiding this comment.
this we need to add to the genesis info type
Comment on lines
+20
to
+22
| // if chain_spec.is_interop_active_at_timestamp(timestamp) { | ||
| // OpSpecId::INTEROP | ||
| // } else |
Collaborator
There was a problem hiding this comment.
afaik there are no evm changes for interop?
possible that we don't need to roll a new spec but probably should anyway for consistency
FYI @klkvr
This was referenced Feb 19, 2025
Contributor
Author
|
@mattsse thanks for the lightning speed! |
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Feb 19, 2025
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation Closes #446 For paradigmxyz/reth#14582 ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
emhane
approved these changes
Feb 19, 2025
Collaborator
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
lgtm! next we need to open an issue in https://github.com/bluealloy/revm to add the OpSpecId::Interop as well
| Holocene, | ||
| /// Isthmus: <https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/isthmus/overview.md> | ||
| Isthmus, | ||
| /// Interop: <https://github.com/ethereum-optimism/specs/blob/main/specs/protocol/interop/overview.md> |
Collaborator
There was a problem hiding this comment.
link is 404. better add a code comment // todo: add link to specs when available
Contributor
Author
|
@emhane Thanks! |
docker-dragonmj9ol
added a commit
to docker-dragonmj9ol/op-alloy
that referenced
this pull request
Nov 6, 2025
<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation Closes alloy-rs/op-alloy#446 For paradigmxyz/reth#14582 ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14553
Adds interop hardfork to all relevant places.
2 places commented out, because it needs changes in alloys and revm