refactor updates #18
refactor updates #18
Conversation
|
@AlvinHon Please also advise on whether EngineCommand should be moved into engine.rs or in peer.rs |
It should be in engine.rs. |
|
I have some comments:
|
src/peer.rs
Outdated
| pub async fn start(config: Config, handlers: Vec<Box<dyn Fn(PublicAddress, Message) + Send>>) -> Result<Peer, PeerStartError> { | ||
| let swarm = set_up_transport(&config).await?; | ||
| let swarm = establish_network_connections(swarm, &config)?; | ||
| let (handle, sender) = main_loop(swarm, &config, handlers)?; |
There was a problem hiding this comment.
"main_loop" doesn't seem to be a good naming...?
There was a problem hiding this comment.
i agree, maybe "spawn_event_loop" , "start_event_detection" or "spawn_events_handler" ? any suggestions?
src/messages.rs
Outdated
| impl TryFrom<(libp2p::gossipsub::Message, pchain_types::cryptography::PublicAddress)> for Message { | ||
| type Error = MessageConversionError; | ||
|
|
||
| fn try_from((message , local_public_address): (libp2p::gossipsub::Message, pchain_types::cryptography::PublicAddress)) |
There was a problem hiding this comment.
Move this and the MessageConversionError into conversions.rs as these are all related to conversions
Changes
TryFrom<libp2p::gossipsub::Message>for pchain Message.