Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
renamed MessageError to MessageConversionError
  • Loading branch information
ong-jonas committed Oct 23, 2023
commit e69a8dfc11486f260ebd3c7e27b27d7c61c46ca0
16 changes: 8 additions & 8 deletions src/messages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ impl From<Message> for Vec<u8> {
}

impl TryFrom<(libp2p::gossipsub::Message, pchain_types::cryptography::PublicAddress)> for Message {
type Error = MessageError;
type Error = MessageConversionError;

fn try_from((message , local_public_address): (libp2p::gossipsub::Message, pchain_types::cryptography::PublicAddress))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this and the MessageConversionError into conversions.rs as these are all related to conversions

-> Result<Self, Self::Error> {
Expand Down Expand Up @@ -112,20 +112,20 @@ fn identify_topics(topic_hash: TopicHash, addr: PublicAddress) -> Result<Topic,
pub struct InvalidTopic;

#[derive(Debug)]
pub enum MessageError {
pub enum MessageConversionError {
DeserializeError(std::io::Error),
InvalidTopic(InvalidTopic),
}

impl From<InvalidTopic> for MessageError {
fn from(error: InvalidTopic) -> MessageError {
MessageError::InvalidTopic(error)
impl From<InvalidTopic> for MessageConversionError {
fn from(error: InvalidTopic) -> MessageConversionError {
MessageConversionError::InvalidTopic(error)
}
}

impl From<std::io::Error> for MessageError {
fn from(error: std::io::Error) -> MessageError {
MessageError::DeserializeError(error)
impl From<std::io::Error> for MessageConversionError {
fn from(error: std::io::Error) -> MessageConversionError {
MessageConversionError::DeserializeError(error)
}
}

Expand Down