pchain_network v0.6 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyulka
reviewed
Dec 7, 2023
src/conversions.rs
Outdated
|
|
||
| /// Check the distance between 2 peers. Subscribe to new peer's individual topic | ||
| /// if the distance is below [MAX_REPLICA_DISTANCE] | ||
| pub(crate) fn is_close_peer(peer_1: &PeerId, peer_2: &PeerId) -> bool { |
There was a problem hiding this comment.
I don’t think this should be in the conversions module.
Any reason why this function should be in the "conversions" module?
There was a problem hiding this comment.
Will shift this to peer module.
lyulka
reviewed
Dec 7, 2023
There was a problem hiding this comment.
I'm looking at PeerStartError::SystemConfigError. Its itemdoc says that the variant corresponds to the case where we "Failed to read from system configuration path". However, I don't see anywhere in the code where we read a file at a path.
There was a problem hiding this comment.
I've updated it with the correct error variant.
lyulka
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network v0.6
"consensus" -> "hotstuff_rs"
base64url(public_addr) -> "hotstuff_rs/" + base64url(public_addr)