-
Notifications
You must be signed in to change notification settings - Fork 0
pchain_network v0.6 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
990251c
mailbox feature
ong-jonas 2396d8d
merge refactor into feature
ong-jonas 8e73502
message ID no longer overridden
ong-jonas 28d9103
removed engine.rs
ong-jonas d55849b
renamed SMR topics to hotstuff_rs
ong-jonas 7da376a
added mailbox subscription feature
ong-jonas 043800a
update network tests
ong-jonas dd322db
removed droppedtx message type
ong-jonas cde45ef
added different message handlers and updated hotstuff dependency to 0.3
ong-jonas 0f945a7
updated config keypair to pchain type
ong-jonas 0879474
added helper function in network tests
ong-jonas 17673c0
mempool messages accepts V1 or V2
ong-jonas 4a7c7aa
Update lib.rs
ef789f2
Fix: serialize TransactionV1 and TransactionV2 separately in messages.rs
725d99b
Update libp2p deprecated package
30d2dd4
update message serialization and handler channels
ong-jonas 994834c
update message handlers to FnMut
f01c511
FIX: removed deprecated dependencies
ong-jonas 54ffb64
REFACTOR: removed with_dns, added nodelay(true)
ong-jonas 29ea7c7
REFACTOR: try_from to filter_gossipsub_messages, Vec<msg_handlers> to…
ong-jonas 6b3543d
deps: update dependency to hotstuff_rs
ong-jonas 5a7c61e
refactor: update pchain-types dependency version
ong-jonas 8556c0f
Merge branch 'v0.5' into mailbox/feature
ong-jonas 5b379a9
REFACTOR: documentation update to reflect single message handler
ong-jonas f66e4c2
refactor: moved is_close_peer function to peer.rs and updated PeerSta…
ong-jonas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
updated config keypair to pchain type
- Loading branch information
commit 0f945a7891bc3e7b91b84fd71eb298a70dc62df4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking at
PeerStartError::SystemConfigError. Its itemdoc says that the variant corresponds to the case where we "Failed to read from system configuration path". However, I don't see anywhere in the code where we read a file at a path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it with the correct error variant.