This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix test collator compilation failure #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fine by me. @bkchr ? |
Member
|
No, I think we should copy the function. |
Using a feature gate like "test-features" is problematic because it is leaky: depending on situational considitons such as the current working directory when compilation is attempted, the feature may or may not be applied, which makes success inconsistent. It's simpler in this case to copy a dozen lines of code than to work out all the issues with test features.
Contributor
Author
|
OK, copied the function. |
Merged
bkchr
approved these changes
May 7, 2020
Maharacha
pushed a commit
to Maharacha/cumulus
that referenced
this pull request
May 10, 2023
* to be released as 0.6.6 * add protocol-id `nctr-k, nctr-w, nctr-r` * regenesis * pimp regenesis script to default to non-destrictive action * re-genesis with GA artifact encointer-collator 0.6.6-d43a118-x86_64-linux-gnu run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.