This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix docker script #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a feature gate like "test-features" is problematic because it is leaky: depending on situational considitons such as the current working directory when compilation is attempted, the feature may or may not be applied, which makes success inconsistent. It's simpler in this case to copy a dozen lines of code than to work out all the issues with test features.
Contributor
Author
|
Done. |
bkchr
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the dockerized demo: running the commands in the README now produces a parachain which changes over time:
$ pjs query.parachains.heads 100 { "heads": "0x10bf9ef628372d6eb8eb25ab4093cf94f195b86306669edf18accec01397354848cd8cbe8d460c5b2c6245aa74714308c9182c2bcb6476beaa4d7dde36f51888c2814aaa038f0eeac57daa7cab123acd057097b48fd259c1091ec20a43fa362e9500" } $ sleep 90 && pjs query.parachains.heads 100 { "heads": "0xf364c2e0bcc3e9e9c7a4616d7d323200d2f4da8cb13481e05f5b88efa0fb7dc76cec2ee89118e35279cd45f2fbc56a32d92d6349feda7ae7c3b31ca1674868af255356176fa13422a1fa3fb2717e72f4ec1a7a807826c1309f0d139a73e49bf03500" } $ sleep 90 && pjs query.parachains.heads 100 { "heads": "0x89675e0719b23ab747e6014c421edc63e471f3ffc294780d611a1aca13cc41e29020de8c6c804a9ea58e799cc90a7be2403a773178a639bbe789a3a4e371d6bdf80790d90c538da278461376b70f6d0c04ea568c73242d38c514c3d1f2c93f8aab00" }