This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Rococo Parachain XCM Adjustments #936
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
A3-inprogress
B0-silent
gilescope
reviewed
Jan 26, 2022
ccccccnckuhdkurdfdlbnirhtfcdncknvceelecdeeek
KiChjang
reviewed
Feb 1, 2022
apopiak
commented
Feb 3, 2022
Comment on lines
104
to
105
| // TODO: Replace with version implemented on MultiLocation here: | ||
| // https://github.com/paritytech/polkadot/pull/4827 |
Contributor
Author
There was a problem hiding this comment.
XCM v3 might take a while to be merged. I can just create an issue to track this.
KiChjang
approved these changes
Feb 18, 2022
stiiifff
pushed a commit
to stiiifff/cumulus-asset-fees
that referenced
this pull request
Jun 22, 2022
Contributor
Contributor
|
IIRC, the discussion we had before was that Statemint/e shouldn't view the relay chain as a reserve for DOT/KSM as it can cause problems with reserves drainage via the mixed usage of asset teleportation and reserve transfers. Given so, we probably do not need to allow Statemint to recognize the relay chain as a reserve. However, the |
the-right-joyce
added
A0-please_review
the-right-joyce
added
the
C1-low
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
AssetsFromfilter to allow for suffixes longer than 1Junctionto be compatible with the newPalletInstanceprefix introduced by Update XCM MultiLocation prefixes for assets #831Questions coming out of this:
fn match_prefix(self, prefix: MultiLocation)onMultiLocation? --> Yes: Addstarts_withfunction toMultiLocationandJunctionspolkadot#4835