This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add matches_prefix function to MultiLocation and Junctions
#4827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apopiak
added
A0-please_review
shawntabrizi
approved these changes
Feb 1, 2022
bkchr
reviewed
Feb 1, 2022
| /// assert!(!m.matches_prefix(&X1(PalletInstance(3)))); | ||
| /// # } | ||
| /// ``` | ||
| pub fn matches_prefix(&self, prefix: &MultiLocation) -> bool { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn matches_prefix(&self, prefix: &MultiLocation) -> bool { | |
| pub fn starts_with(&self, prefix: &MultiLocation) -> bool { |
Sounds more like the other methods available in rust
| if self.len() < prefix.len() { | ||
| return false | ||
| } | ||
| for i in 0..prefix.len() { |
Member
There was a problem hiding this comment.
Suggested change
| for i in 0..prefix.len() { | |
| prefix.iter().zip(self.iter()).all(|l, r| l == r) |
This could be used to replace the rest of the function
Contributor
Author
There was a problem hiding this comment.
That's how I implemented it in Cumulus, but here I figured I'd keep to the imperative style of match_and_split 😄
Can definitely do.
| /// # Example | ||
| /// ```rust | ||
| /// # use xcm::v0::{Junction::*, MultiLocation::*}; | ||
| /// # fn main() { |
Member
There was a problem hiding this comment.
Suggested change
| /// # fn main() { |
Rust does this automatically
| /// assert!(m.matches_prefix(&m)); | ||
| /// assert!(!m.matches_prefix(&X2(Parent, GeneralIndex(99)))); | ||
| /// assert!(!m.matches_prefix(&X1(PalletInstance(3)))); | ||
| /// # } |
KiChjang
reviewed
Feb 2, 2022
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
Code looks good, but was wondering if match_and_split can use match_prefix/starts_with underneath as well.
Contributor
|
Code should also be made against the XCMv3 branch instead of master, i.e. against |
gavofyork
added
A5-grumble
and removed
A0-please_review
Contributor
Author
|
suderseded by #4835 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin 😉
Motivated by paritytech/cumulus#936 (comment)
Key motivation:
match_and_splitonly allows a singleJunctionafter the prefix but it can be useful to be able to just check for a prefix and ignore what comes after.Possible extension: We could introduce a corresponding
match_and_split_tail(or similar, just a naming suggestion) to allow splitting off arbitrary suffixes.