Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 8, 2021

Updates the requirements on scale-info to permit the latest version.

Release notes

Sourced from scale-info's releases.

v0.6.0

Added

Fixed

Changelog

Sourced from scale-info's changelog.

[0.6.0] - 2021-02-05

Added

Fixed

[0.5.0] - 2021-01-27

Added

Changed

Fixed

[0.4.1] - 2020-10-11

Fixed

[0.4.0] - 2020-10-05

Added

[0.3.0] - 2020-07-03

Changed

[0.2.0] - 2020-06-17

Changed

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@ordian
Copy link
Contributor

ordian commented Feb 16, 2021

cc @ascjones any tips how to make it compile?

* master:
  build(deps): update sysinfo requirement from 0.15.3 to 0.16.3 (#526)
  CI: add a workaround for build issue (#527)
  parity-util-mem: use ios compilation conditions same as macos. (#522)
@ascjones
Copy link
Contributor

cc @ascjones any tips how to make it compile?

Hm yes it does assume that there is a direct dependency on parity-scale-codec. There was discussion about whether to reexport it and use that from the macro: paritytech/scale-info#61 (comment).

Maybe cases like this should make us reconsider.

@ordian
Copy link
Contributor

ordian commented Feb 16, 2021

Maybe cases like this should make us reconsider.

yeah, we generate codec impls via macro and don't depend on it directly, the compile error was super confusing as it worked fine with scale-info 0.5

@ordian ordian requested review from ascjones and dvdplm February 17, 2021 09:48
impl-num-traits = { version = "0.1.0", path = "impls/num-traits", default-features = false, optional = true }
impl-rlp = { version = "0.3", path = "impls/rlp", default-features = false, optional = true }
scale-info = { version = "0.6", features = ["derive"], default-features = false, optional = true }
codec-info = { package = "scale-info", version = "0.6", features = ["derive"], default-features = false, optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rename it? To leave "scale-info" available as a feature name? If yes, how about scale-info-crate? It sucks too but at least it's clearer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will rename to scale-info-crate if that's clearer.

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ordian ordian merged commit db7c985 into master Feb 17, 2021
@ordian ordian deleted the dependabot/cargo/scale-info-0.6 branch February 17, 2021 13:44
@ascjones
Copy link
Contributor

Maybe cases like this should make us reconsider.

yeah, we generate codec impls via macro and don't depend on it directly, the compile error was super confusing as it worked fine with scale-info 0.5

paritytech/scale-info#106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants