Don't fail with "check that the PR belongs to a project column."

[ordian]

Example: paritytech/polkadot#1571

Please don't return an error in this case and assume only 1 review is required.

[rphmeier]

Yeah, there should be default or fallback configuration for issues that are not in a project. We don't even use projects that much in Parity so there shouldn't be this hard requirement for us to use them.

[ordian]

I assume is related to Process.json file: https://github.com/paritytech/polkadot/blob/master/Process.json, but we use projects only for issues, not PRs, at least in Polkadot, so yeah, please provide a fallback.

[sjeohp-zz]

Thanks Andronik.

• If move AssignmentKind and CoreAssigment to scheduler polkadot#1571 was tagged insubstantial it would have been merged (one core-dev approval is enough).
• If @rphmeier had requested the merge, it would have been merged (request from a substrateteamlead).

Otherwise the possibilities that occur to me are:

• Allow merging any PR with a single core-dev approval. I believe this would not be a welcome change on Substrate but min-approvals could be added to Process.json as a repository-wide configuration option and be set to 1 for Polkadot.
• Allow merging with a single substrateteamlead approval. Currently substrateteamleads can request a merge (mainly so that @bkchr and anyone else who is not a listed project owner could merge) so an approval should probably also suffice.

[ordian]

Thanks for the insight, so would it have been merged if the PR had 2 approvals? It wasn't clear from the error message, I would suggest changing the message to something more user-friendly.

We don't use insubstantial tags for code changes as per paritytech/polkadot#1413 (comment).

Allow merging with a single substrateteamlead approval. Currently substrateteamleads can request a merge (mainly so that bkchr and anyone else who is not a listed project owner could merge) so an approval should probably also suffice.

I think this is a viable option.

[sjeohp-zz]

Thanks for the insight, so would it have been merged if the PR had 2 approvals? It wasn't clear from the error message, I would suggest changing the message to something more user-friendly.

Correct and noted, thanks.

[sjeohp-zz]

Allow merging with a single substrateteamlead approval.

This is implemented.