Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

move AssignmentKind and CoreAssigment to scheduler #1571

Merged
ordian merged 2 commits into from
Aug 17, 2020
Merged

move AssignmentKind and CoreAssigment to scheduler #1571

ordian merged 2 commits into from
Aug 17, 2020

Conversation

@ordian
Copy link

@ordian ordian commented Aug 12, 2020

Fixes #1484.

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 12, 2020
ordian
ordian commented Aug 12, 2020
View reviewed changes
node/subsystem/src/messages.rs
/// The information on scheduler assignments that some somesystems may be querying.
#[derive(Debug, Clone)]
pub struct SchedulerRoster {
Copy link
Author

@ordian ordian Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is not needed anymore.

rphmeier
rphmeier approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rphmeier rphmeier added A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Aug 17, 2020
@rphmeier
Copy link
Contributor

rphmeier commented Aug 17, 2020

needs a merge with master

Merge branch 'master' into ao-refactor-primitives
32fefa6 
* master:
  overseer: fix build (#1596)
  Companion PR for #6862 (#1564)
  implement collation generation subsystem (#1557)
  Add spawn_blocking to SubsystemContext (#1570)
  Companion PR for #6846 (#1568)
  overseer: add a test to ensure all subsystem receive msgs (#1590)
  Implementer's Guide: Flesh out more details for upward messages (#1556)
  Make parachain validation wasm executor functional (#1574)
  Use async test helper to simplify node testing (#1578)
  guide: validation data refactoring (#1576)
  Remove v0 parachains runtime (#1501)
  [CI] Add github token to generate-release-text (#1581)
  Allow using any polkadot client instead of enum Client (#1575)
  service/src/lib: Update authority discovery construction (#1563)
  Update .editorconfig to what we have in practice (#1545)
  Companion PR for substrate #6672 (#1560)
  pre-redenomination tockenSymbol change (#1561)
@ordian
Copy link
Author

ordian commented Aug 17, 2020

bot merge

@ghost
Copy link

ghost commented Aug 17, 2020

Missing process info; check that the PR belongs to a project column.

@ordian ordian mentioned this pull request Aug 17, 2020
Closed
@ordian ordian merged commit a91b117 into master Aug 17, 2020
@ordian ordian deleted the ao-refactor-primitives branch August 17, 2020 17:26
ordian pushed a commit that referenced this pull request Aug 19, 2020
Merge branch 'master' into ao-job-manager-dont-bring-down-subsystem-o…
473587a 
…n-race-condition

* master:
  initial prometheus metrics (#1536)
  Companion for Substrate 6868 (WeightInfo for System, Utility, and Timestamp) (#1606)
  Promote `HrmpChannelId` and supply more docs (#1595)
  move AssignmentKind and CoreAssigment to scheduler (#1571)
  overseer: fix build (#1596)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rphmeier rphmeier rphmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove CoreAssignment from primitives and move back to Scheduler module

3 participants

@ordian @rphmeier