Skip to content

Add environmental variable to track decoded instructions #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
franciscoaguirre merged 7 commits into from
Aug 31, 2023
Merged

Add environmental variable to track decoded instructions #1320

franciscoaguirre merged 7 commits into from
Aug 31, 2023

Conversation

@franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Aug 30, 2023

Description

Limits number of instructions that can be decoded.

@franciscoaguirre franciscoaguirre self-assigned this Aug 30, 2023
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Aug 30, 2023
@franciscoaguirre franciscoaguirre marked this pull request as ready for review August 30, 2023 19:47
@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented Aug 30, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 30, 2023 •
edited
Loading

"$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" was queued.

Comment bot cancel 5-36c8f7c1-8d60-4b03-b374-54524ef2268b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 30, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result:

ValidationError: "id" is required
ValidationError: "id" is required
{"message":{"base":["Reference not found"]}}

@franciscoaguirre
Copy link
Contributor Author

franciscoaguirre commented Aug 30, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 30, 2023 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3503809 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-a8fbcad6-09a3-4fda-9118-ebf87f715c84 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 30, 2023

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3503809 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3503809/artifacts/download.

@ggwpez ggwpez requested a review from gavofyork August 31, 2023 11:15
ggwpez
ggwpez reviewed Aug 31, 2023
View reviewed changes
@franciscoaguirre franciscoaguirre merged commit 995d81f into master Aug 31, 2023
@franciscoaguirre franciscoaguirre deleted the cis-xcm-decoding-limit branch August 31, 2023 16:42
ordian added a commit that referenced this pull request Sep 1, 2023
@ordian
Merge branch 'master' into s0me0ne/candidate-session-index
40e3da9 
* master: (25 commits)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  Renames API (#1186)
  Rename `polkadot-parachain` to `polkadot-parachain-primitives` (#1334)
  Add README to project root (#1253)
  Add environmental variable to track decoded instructions (#1320)
  Fix polkadot-node-core-pvf-prepare-worker build with jemalloc (#1315)
  Sassafras primitives (#1249)
  Restructure `dispatch` macro related exports (#1162)
  backing: move the min votes threshold to the runtime (#1200)
  Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.4 (#1326)
  Remove `substrate_test_utils::test` (#1321)
  remove disable-runtime-api (#1328)
  [ci] add more jobs for pipeline cancel, cleanup (#1314)
  ...
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@franciscoaguirre @Daanvdplas
Add environmental variable to track decoded instructions (#1320)
9dc65fb 
* Add environmental variable to track decoded instructions

* Fix doc tests

* Fix manifest formatting

* ".git/.scripts/commands/fmt/fmt.sh"

* Add one more test

* Add SetAppendix in test

---------

Co-authored-by: command-bot <>
@rimbi rimbi mentioned this pull request Sep 25, 2023
Merged
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@ashutoshvarma ashutoshvarma mentioned this pull request Feb 27, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamaharon liamaharon Awaiting requested review from liamaharon

@gavofyork gavofyork Awaiting requested review from gavofyork

@ggwpez ggwpez Awaiting requested review from ggwpez

1 more reviewer

@KiChjang KiChjang KiChjang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@franciscoaguirre franciscoaguirre

Labels

T6-XCM This PR/Issue is related to XCM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franciscoaguirre @KiChjang @ggwpez