-
Notifications
You must be signed in to change notification settings - Fork 384
Upgrade to polkadot v1.1.0 #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good so far (I know it's not done yet :) ) |
92c8b6d to
88722b0
Compare
|
Coverage generated "Tue Oct 10 10:10:49 UTC 2023": Master coverage: 87.39% |
02da56b to
a403c2d
Compare
6e5f333 to
e819d76
Compare
notlesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, haven't made it through everything yet but wanted to push my comments so far.
notlesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some comments that are worth reviewing though :)
- `check --release` is done. - `check --tests` is in progress
- `check --tests` is in progress
- `check --tests` is done
This reverts commit 8fb8e24.
6547e2f to
7ee2ad9
Compare
What does it do?
Upgrades the dependencies
polkadot-sdkfrontiermoonkitormlpallet-crowdloansto the version
moonbeam-polkadot-v1.1.0.What important points reviewers should know?
Breaking Changes
Eth::newaccepts two additional parameters:pending_create_inherent_data_providers: which requires time inherent and ,in our case,ParachainInherentDataprovider. Since these are needed in a pending context, providing dummy values is enough.pending_consensus_data_provider: Through which we providednimbus author id(by getting it from the last best block) andvrfdigests.test/suites/dev/test-xcm-v3/test-mock-dmp-queue.ts.try-runtimesubcommand has been removed and migrated to the standalone-cli.AllowPaidExecutionFrombarrier now prevents multiple currency transfers.polkadot-sdkhas new names:xcm->staging-xcmxcm-executor->staging-xcm-executorxcm-builder->staging-xcm-builderkusama-runtime->staging-kusama-runtimeXcmVersionedXcmmessage in the ts tests has been renamed toStagingXcmVersionedXcmframe_system::Config,Indexwas renamed toNonceBlockNumber,HeaderandHoldIdentifierwere removedBlock,AliasersandRuntimeHoldReasonwere addedparas::Confighas a new associated typeOnNewHeadhrmp::Confighas a new associated typeChannelManagerpallet_message_queue::Confighas a new associated typeQueuePausedQuerybuild_storageandassimilate_storageis now provided viasp_runtime::BuildStorageinstead offrame_support::traits::GenesisBuildxcm_executor::traits::Convertwas replaced withxcm_executor::traits::ConvertLocationwhose APIs differ.improved_panic_error_reportingfeature insp_ioandchain-errorinparity-scale-codecto pass certain test cases.hrmp::WeightInfo::force_open_hrmp_channelaccepts a newu32argumentWeightTrader::buy_weightmethod takes an additionalXcmContextparameter.pallet_xcm_benchmarks::generic::Configrequires a new methodalias_originIs there something left for follow-up PRs?
start_full_nodeandstart_collatorAPIsmoonriver-nativeshould be renamed.What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?