Skip to content

Relax approval requirements on CI files #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2023
Merged

Relax approval requirements on CI files #2564

merged 3 commits into from
Dec 6, 2023

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Nov 30, 2023

  • Remove the old Cumulus checks as these files do not exist anymore
  • Relax requirements on CI files to also give two core devs the right to change these files
  • Relax requirements on the review bot configuration itself as well.

@bkchr
Relax approval requirements on CI files
30dbeda 
- Remove the old Cumulus checks as these files do not exist anymore
- Relax requirements on CI files to also give two core devs the right to
  change these files
- Relax requirements on the review bot configuration itself as well.
@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Nov 30, 2023
@bkchr bkchr requested review from a team as code owners November 30, 2023 08:56
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 30, 2023 09:34
ggwpez
ggwpez reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also relax the bootnode approval requirement from 3 to 2?

.github/review-bot.yml Outdated
- name: CI files
countAuthor: true
condition:
include:
Copy link
Member

@ggwpez ggwpez Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a yaml formatter could be a good addition to the CI

.github/review-bot.yml
@@ -1,30 +1,34 @@
rules:
Copy link
Member

@ggwpez ggwpez Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see asset-hub-kusama, bridge-hub-kusama and similar in the file, ctrl+f cumulus/parachains/runtimes.

seadanda
seadanda reviewed Nov 30, 2023
View reviewed changes
@seadanda seadanda mentioned this pull request Dec 5, 2023
Merged
@bkchr bkchr merged commit 833478f into master Dec 6, 2023
@bkchr bkchr deleted the bkchr-relax-approval-rights-ci branch December 6, 2023 22:16
bkchr pushed a commit that referenced this pull request Dec 7, 2023
@seadanda
Remove testnets-common (#2620)
814b938 
`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
#2564 and there are
[plans](#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.
btwiuse added a commit to btwiuse/pdk that referenced this pull request Dec 8, 2023
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
ff0e924 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse added a commit to btwiuse/pdk that referenced this pull request Dec 8, 2023
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
3881bbd 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
ordian added a commit that referenced this pull request Dec 11, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-disputes
80f371e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
ordian added a commit that referenced this pull request Dec 15, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
9842b9e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
btwiuse added a commit to btwiuse/pdk that referenced this pull request Dec 29, 2023
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
8d1e7e3 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse added a commit to btwiuse/pdk that referenced this pull request Jan 19, 2024
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
6f0e7b5 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse added a commit to btwiuse/pdk that referenced this pull request Jan 26, 2024
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
1815428 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse added a commit to btwiuse/pdk that referenced this pull request Feb 2, 2024
@btwiuse @seadanda @JoshOrndorff
squash: joshy no rocks db (#2)
7568f43 
* Remove `testnets-common` (paritytech#2620)

`testnets-common` was introduced recently to start to separate testnet
parachain configurations from those of Polkadot and Kusama.

The `locks-review` and `polkadot-review` requirements are removed from
`parachains-common` in
paritytech#2564 and there are
[plans](paritytech#2564 (comment))
to move the Polkadot and Kusama contents of that package to the
fellowship, `testnets-common` is no longer needed.

This PR removes the crate and replaces uses of it in
`collectives-westend`, the only place it is currently used.

* cumulus-client-cli

* substrate-test-utils

* checkpoint

* remove outdated comment

* fmt

* polkadot-cli

* try-runtime

* bunch of cumulus stuff

* cumulus-test-client

* Mke cumulus test service use paritydb

* josh: disable db feature

---------

Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Joshy Orndorff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggwpez ggwpez ggwpez left review comments

@seadanda seadanda seadanda left review comments

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@alvicsam alvicsam alvicsam approved these changes

+4 more reviewers

@rcny rcny rcny approved these changes

@mrcnski mrcnski mrcnski approved these changes

@Bullrich Bullrich Bullrich approved these changes

@sergejparity sergejparity sergejparity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bkchr @rcny @mrcnski @EgorPopelyaev @Bullrich @ggwpez @seadanda @alvicsam @sergejparity