Remove testnets-common
#2620
Merged
Remove testnets-common
#2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
added
R0-no-crate-publish-required
Contributor
Author
|
bot fmt |
|
@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4607888 was started for your command Comment |
|
@seadanda Command |
bkchr
approved these changes
Dec 7, 2023
joepetrowski
approved these changes
Dec 7, 2023
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Dec 8, 2023
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Dec 8, 2023
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
This was referenced Dec 8, 2023
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Dec 29, 2023
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
bkchr
added a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Jan 4, 2024
This PR brings the Kusama and Polkadot constants for System Parachains into the control of the Fellowship. Following up on paritytech/polkadot-sdk#2620 and paired with paritytech/polkadot-sdk#2666. Types are still used from the `parachains-common` crate, but constants are moved into a new crate `system-parachains-constants` in this repo. The re-exports `pub use parachains_common as common` in both asset hubs and collectives have been removed. This is a breaking change for anybody using them in this way, but these should be directly imported from `parachains-common`. This should be noted on the changelog. --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Jan 19, 2024
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Jan 26, 2024
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
btwiuse
added a commit
to btwiuse/pdk
that referenced
this pull request
Feb 2, 2024
* Remove `testnets-common` (paritytech#2620) `testnets-common` was introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama. The `locks-review` and `polkadot-review` requirements are removed from `parachains-common` in paritytech#2564 and there are [plans](paritytech#2564 (comment)) to move the Polkadot and Kusama contents of that package to the fellowship, `testnets-common` is no longer needed. This PR removes the crate and replaces uses of it in `collectives-westend`, the only place it is currently used. * cumulus-client-cli * substrate-test-utils * checkpoint * remove outdated comment * fmt * polkadot-cli * try-runtime * bunch of cumulus stuff * cumulus-test-client * Mke cumulus test service use paritydb * josh: disable db feature --------- Co-authored-by: Dónal Murray <[email protected]> Co-authored-by: Joshy Orndorff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testnets-commonwas introduced recently to start to separate testnet parachain configurations from those of Polkadot and Kusama.The
locks-reviewandpolkadot-reviewrequirements are removed fromparachains-commonin #2564 and there are plans to move the Polkadot and Kusama contents of that package to the fellowship,testnets-commonis no longer needed.This PR removes the crate and replaces uses of it in
collectives-westend, the only place it is currently used.