remove deprecated type 'GenesisConfig' #3378

RomarQ · 2024-02-18T21:01:02Z

Description

Removed deprecated type GenesisConfig from the codebase.

Closes #175

Checklist

My PR includes a detailed description as outlined in the "Description" section above
My PR follows the labeling requirements of this project (at minimum one label for T
required)
I have made corresponding changes to the documentation (if applicable)

philoniare · 2024-02-19T02:55:27Z

@RomarQ looks like the tests are not passing yet? https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5249923

RomarQ · 2024-02-19T08:44:23Z

bot update-ui

command-bot · 2024-02-19T08:44:27Z

@RomarQ Requester could not be detected as a member of an allowed organization.

seadanda · 2024-02-19T09:15:09Z

bot update-ui

command-bot · 2024-02-19T09:15:13Z

@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5252722 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-77b7f828-e991-4629-88e7-dbc48972a048 to cancel this command or bot cancel to cancel all commands in this pull request.

prdoc/pr_3378.prdoc

command-bot · 2024-02-19T09:39:14Z

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5252722 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5252722/artifacts/download.

RomarQ · 2024-02-19T11:02:23Z

bot update-ui

Hi @seadanda, the bot update-ui did not generate any artifacts. Locally, I am probably using a different version (in the CI I see version 1.75 and 1.77 nightly).

What is the best way to make sure the ui tests don't mismatch? It is not clear by looking into the contributor guidelines.

substrate/frame/support/test/tests/construct_runtime_ui/deprecated_where_block.stderr

This reverts commit 90bea09.

seadanda · 2024-02-20T09:37:35Z

bot update-ui

command-bot · 2024-02-20T09:37:40Z

@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5272134 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-4e8e39e1-9401-41a3-981e-f56923453fb1 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-02-20T10:00:19Z

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5272134 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5272134/artifacts/download.

RomarQ · 2024-02-20T10:16:21Z

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5272134 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5272134/artifacts/download.

@seadanda am I confusing something or the bot update-ui also does not detect any diffs?

seadanda · 2024-02-20T11:39:42Z

I've just cloned your branch to have a look and realised that it seems like there's a fair bit left to do to remove GenesisConfig

RomarQ · 2024-02-20T12:13:25Z

I've just cloned your branch to have a look and realised that it seems like there's a fair bit left to do to remove GenesisConfig

I could not find any references that needed to be removed, also all build actions are green. I will have another look at it later today.

substrate/client/chain-spec/src/genesis_config_builder.rs

michalkucharczyk

Looks good, thank you. I left some re-wording/improvements in docs.

Co-authored-by: Michal Kucharczyk <[email protected]>

kianenigma · 2024-03-04T10:16:37Z

substrate/frame/support/procedural/src/construct_runtime/expand/config.rs


-		#[cfg(any(feature = "std", test))]
-		#[deprecated(note = "GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.")]
-		pub type GenesisConfig = RuntimeGenesisConfig;


if you see in FRAME, there are a few more deprecated items that we can already remove. You do them in a follow up if interested :) Assuming min 6mo has passed since being marked deprecated

michalkucharczyk · 2024-03-04T10:55:12Z

There is also related deprecated GenesisBuild trait.

Maybe we could also remove it in this PR? (a follow-up PR also would fine.)

RomarQ · 2024-03-04T11:23:56Z

There is also related deprecated GenesisBuild trait.

Maybe we could also remove it in this PR? (a follow-up PR also would fine.)

I will remove GenesisBuild in a follow up PR. I prefer to keep this PR as simple as possible.

michalkucharczyk · 2024-03-05T08:57:43Z

This job check-runtime-migration-westend is sometimes failing, not sure if someone is currently working on it. I think we can merge it.

RomarQ · 2024-03-05T11:07:37Z

This job check-runtime-migration-westend is sometimes failing, not sure if someone is currently working on it. I think we can merge it.

There are a few CI required status that never got reported. Is it something that needs a manual trigger from merge_group?

michalkucharczyk · 2024-03-05T11:15:53Z

bot fmt

command-bot · 2024-03-05T11:15:59Z

@michalkucharczyk https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5439300 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-b85754e3-9017-4ab3-81b7-1dbb22dff10d to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-05T11:18:12Z

@michalkucharczyk Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5439300 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5439300/artifacts/download.

michalkucharczyk · 2024-03-05T11:19:00Z

@RomarQ would you please fix formatting? (bot fmt is not working on external repos).

RomarQ · 2024-03-05T12:14:42Z

@RomarQ would you please fix formatting? (bot fmt is not working on external repos).

Done

# Description Removed deprecated type `GenesisConfig` from the codebase. Closes paritytech#175 # Checklist - [x] My PR includes a detailed description as outlined in the "Description" section above - [x] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) - [x] I have made corresponding changes to the documentation (if applicable) --------- Co-authored-by: Liam Aharon <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]>

remove deprecated type 'GenesisConfig'

cfad225

RomarQ requested a review from a team as a code owner February 18, 2024 21:01

RomarQ and others added 2 commits February 18, 2024 21:02

doc: add prdoc

57b6407

Merge branch 'master' into rq/remove-genesis-config

fbb8814

RomarQ mentioned this pull request Feb 18, 2024

[Deprecation] GenesisConfig -> RuntimeGenesisConfig #175

Closed

RomarQ and others added 2 commits February 19, 2024 07:47

Merge branch 'master' into rq/remove-genesis-config

ea02381

test: update ui test result

90bea09

seadanda added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Feb 19, 2024

seadanda reviewed Feb 19, 2024

View reviewed changes

prdoc/pr_3378.prdoc Show resolved Hide resolved

doc: update prdoc

9b24930

doc: fix crate field in prdoc

82a3d4c

seadanda reviewed Feb 19, 2024

View reviewed changes

substrate/frame/support/test/tests/construct_runtime_ui/deprecated_where_block.stderr Show resolved Hide resolved

seadanda reviewed Feb 19, 2024

View reviewed changes

substrate/frame/support/test/tests/construct_runtime_ui/deprecated_where_block.stderr Show resolved Hide resolved

RomarQ and others added 2 commits February 19, 2024 22:03

Revert "test: update ui test result"

74c4626

This reverts commit 90bea09.

Merge branch 'master' into rq/remove-genesis-config

985b372

RomarQ added 2 commits February 21, 2024 13:48

Merge branch 'master' into rq/remove-genesis-config

be39b9c

Merge branch 'master' into rq/remove-genesis-config

0f6e543

michalkucharczyk reviewed Mar 4, 2024

View reviewed changes

substrate/client/chain-spec/src/genesis_config_builder.rs Outdated Show resolved Hide resolved

michalkucharczyk reviewed Mar 4, 2024

View reviewed changes

substrate/client/chain-spec/src/genesis_config_builder.rs Outdated Show resolved Hide resolved

michalkucharczyk reviewed Mar 4, 2024

View reviewed changes

substrate/client/chain-spec/src/genesis_config_builder.rs Outdated Show resolved Hide resolved

michalkucharczyk approved these changes Mar 4, 2024

View reviewed changes

RomarQ and others added 3 commits March 4, 2024 09:15

Update substrate/client/chain-spec/src/genesis_config_builder.rs

7ce804f

Co-authored-by: Michal Kucharczyk <[email protected]>

Update substrate/client/chain-spec/src/genesis_config_builder.rs

ed0ff00

Co-authored-by: Michal Kucharczyk <[email protected]>

Update substrate/client/chain-spec/src/genesis_config_builder.rs

22ce32e

Co-authored-by: Michal Kucharczyk <[email protected]>

kianenigma approved these changes Mar 4, 2024

View reviewed changes

RomarQ added 2 commits March 4, 2024 21:39

Merge branch 'master' into rq/remove-genesis-config

c804178

Merge branch 'master' into rq/remove-genesis-config

56ac266

RomarQ and others added 2 commits March 5, 2024 12:13

format

6b546d2

Merge branch 'master' into rq/remove-genesis-config

aef705e

michalkucharczyk added this pull request to the merge queue Mar 5, 2024

Merged via the queue into paritytech:master with commit c367ac2 Mar 5, 2024

Aideepakchaudhary mentioned this pull request Oct 14, 2024

Feat: Polkadot v1.8 to v1.9 upgrade Cerebellum-Network/blockchain-node#444

Closed

remove deprecated type 'GenesisConfig' #3378

remove deprecated type 'GenesisConfig' #3378

Uh oh!

Conversation

RomarQ commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

philoniare commented Feb 19, 2024

Uh oh!

RomarQ commented Feb 19, 2024

Uh oh!

command-bot bot commented Feb 19, 2024

Uh oh!

seadanda commented Feb 19, 2024

Uh oh!

command-bot bot commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

command-bot bot commented Feb 19, 2024

Uh oh!

RomarQ commented Feb 19, 2024

Uh oh!

Uh oh!

Uh oh!

seadanda commented Feb 20, 2024

Uh oh!

command-bot bot commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Feb 20, 2024

Uh oh!

RomarQ commented Feb 20, 2024

Uh oh!

seadanda commented Feb 20, 2024

Uh oh!

RomarQ commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalkucharczyk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kianenigma Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

michalkucharczyk commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomarQ commented Mar 4, 2024

Uh oh!

michalkucharczyk commented Mar 5, 2024

Uh oh!

RomarQ commented Mar 5, 2024

Uh oh!

michalkucharczyk commented Mar 5, 2024

Uh oh!

command-bot bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 5, 2024

Uh oh!

michalkucharczyk commented Mar 5, 2024

Uh oh!

RomarQ commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RomarQ commented Feb 18, 2024 •

edited

Loading

command-bot bot commented Feb 19, 2024 •

edited

Loading

command-bot bot commented Feb 20, 2024 •

edited

Loading

RomarQ commented Feb 20, 2024 •

edited

Loading

michalkucharczyk left a comment •

edited

Loading

michalkucharczyk commented Mar 4, 2024 •

edited

Loading

command-bot bot commented Mar 5, 2024 •

edited

Loading