-
Notifications
You must be signed in to change notification settings - Fork 1.1k
remove deprecated type 'GenesisConfig' #3378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michalkucharczyk
merged 26 commits into
paritytech:master
from
RomarQ:rq/remove-genesis-config
Mar 5, 2024
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
cfad225
remove deprecated type 'GenesisConfig'
RomarQ 57b6407
doc: add prdoc
RomarQ fbb8814
Merge branch 'master' into rq/remove-genesis-config
RomarQ ea02381
Merge branch 'master' into rq/remove-genesis-config
RomarQ 90bea09
test: update ui test result
RomarQ 9b24930
doc: update prdoc
RomarQ 82a3d4c
doc: fix crate field in prdoc
RomarQ 74c4626
Revert "test: update ui test result"
RomarQ 985b372
Merge branch 'master' into rq/remove-genesis-config
liamaharon be39b9c
Merge branch 'master' into rq/remove-genesis-config
RomarQ 0f6e543
Merge branch 'master' into rq/remove-genesis-config
RomarQ 43d8b26
fix frame-ui test artifact
RomarQ c4b775e
Merge branch 'master' into rq/remove-genesis-config
RomarQ a85059c
Merge branch 'master' into rq/remove-genesis-config
RomarQ eb6d1a3
Merge branch 'master' into rq/remove-genesis-config
RomarQ 7a174ce
Merge branch 'master' into rq/remove-genesis-config
RomarQ a723b5f
Merge branch 'master' into rq/remove-genesis-config
RomarQ 04c82ad
Merge branch 'master' into rq/remove-genesis-config
RomarQ f0d06bf
raname GenesisConfig in doc comments
RomarQ 7ce804f
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ ed0ff00
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ 22ce32e
Update substrate/client/chain-spec/src/genesis_config_builder.rs
RomarQ c804178
Merge branch 'master' into rq/remove-genesis-config
RomarQ 56ac266
Merge branch 'master' into rq/remove-genesis-config
RomarQ 6b546d2
format
RomarQ aef705e
Merge branch 'master' into rq/remove-genesis-config
RomarQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 | ||
| # See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json | ||
|
|
||
| title: Remove deprecated GenesisConfig | ||
|
|
||
| doc: | ||
| - audience: Runtime Dev | ||
| description: | | ||
| Removes deprecated type `GenesisConfig`, it was replaced by `RuntimeGenesisConfig` on May 24 of 2023. | ||
| The type `GenesisConfig` was deprecated on May 24 of 2023 [#14210](https://github.com/paritytech/substrate/pull/14210) | ||
|
|
||
| crates: | ||
| - name: frame-support-procedural | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,10 +76,6 @@ pub fn expand_outer_config( | |
| #fields | ||
| } | ||
|
|
||
| #[cfg(any(feature = "std", test))] | ||
| #[deprecated(note = "GenesisConfig is planned to be removed in December 2023. Use `RuntimeGenesisConfig` instead.")] | ||
| pub type GenesisConfig = RuntimeGenesisConfig; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you see in FRAME, there are a few more deprecated items that we can already remove. You do them in a follow up if interested :) Assuming min 6mo has passed since being marked deprecated |
||
|
|
||
| #[cfg(any(feature = "std", test))] | ||
| impl #scrate::sp_runtime::BuildStorage for RuntimeGenesisConfig { | ||
| fn assimilate_storage( | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.