This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[CI] Publish draft release redux #1493
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52f07b0. Accidentally pushed to wrong branch...
…sh-draft-release-action
kirushik
reviewed
Jul 29, 2020
Co-authored-by: Kirill Pimenov <[email protected]>
kirushik
reviewed
Jul 29, 2020
| - name: Set up Ruby 2.7 | ||
| uses: actions/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 2.6 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says "Set up Ruby 2.7" just a few lines above
dvdplm
reviewed
Jul 29, 2020
| rustc_stable = ENV['RUSTC_STABLE'] | ||
| rustc_nightly = ENV['RUSTC_NIGHTLY'] | ||
|
|
||
| polkadot_runtime = File.open(polkadot_path + '/runtime/polkadot/src/lib.rs') |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
polkadot_runtime = File.open(filepath) do |f|
f.find {|l| l =~ /spec_version/ }.match(/[0-9]/+).first
end…to make sure you close the file after reading?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout on the file handling :) thanks.
Though for whatever reason, MatchData doesn't have first or last methods...
kirushik
approved these changes
Jul 30, 2020
ordian
added a commit
that referenced
this pull request
Jul 31, 2020
* master: Candidate Validation Subsystem (#1432) reduce slash defer durations (#1504) Implement the Runtime API subsystem (#1494) Companion for #6610 (Balances Weight Trait) (#1425) [CI] Publish draft release redux (#1493) Update README docs related to local build (#1479) Add a default trie-memory-tracker feature to the cli (#1502) Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499) Fix bitfield signing (#1466) Update Substrate, bump versions, clean up sort (#1496) Bump Substrate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an overhaul of the way we publish draft releases on pushing of a new tag.
The old method was a very cumbersome 274-line bash script in addition to some helper functions in
lib.sh.The new version:
Using a real language rather than bash makes it a lot more readable and maintainable, even if you don't know so much Ruby (compared to the weird bash I was having to use).