This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR for Add a DefaultQueue type alias to remove the need to use sp_api::TransactionFor``
#1499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expenses
added
A2-insubstantial
Contributor
Author
|
Is there a way to get the substrate PR merged without switching the branch on this one temporarily so the tests pass? |
Member
|
You don't need to have tests passed here. |
Contributor
|
The tests here shouldn't need to pass for the substrate companion build to pass, I think it only checks whether this PR is mergeable or not (without enforcing all CI tasks here are green). |
bkchr
approved these changes
Jul 29, 2020
Contributor
I have a PR that fixes that. All the tests here will be green. (for all future companion pr) #1455 |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Jul 31, 2020
* master: Candidate Validation Subsystem (#1432) reduce slash defer durations (#1504) Implement the Runtime API subsystem (#1494) Companion for #6610 (Balances Weight Trait) (#1425) [CI] Publish draft release redux (#1493) Update README docs related to local build (#1479) Add a default trie-memory-tracker feature to the cli (#1502) Companion PR for `Add a `DefaultQueue` type alias to remove the need to use `sp_api::TransactionFor`` (#1499) Fix bitfield signing (#1466) Update Substrate, bump versions, clean up sort (#1496) Bump Substrate
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#6761