This repository was archived by the owner on Nov 15, 2023. It is now read-only.
service/src/lib: Update authority discovery construction #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paritytech/substrate#6760 introduces the concept of an authority discovery `Service` allowing one to communicate with an authority discovery `Worker`, e.g. to learn the `Multiaddr`s for a given `AuthorityId`. Along with the new `Service` structure it also alters the authority discovery constructor to return both a worker and a service. This commit adjusts the callside of the constructor, ignoring the `Service` for now.
mxinden
added
A0-please_review
tomaka
approved these changes
Aug 11, 2020
ordian
approved these changes
Aug 12, 2020
ordian
added
A8-mergeoncegreen
and removed
A0-please_review
|
Waiting for commit status. |
|
Merge failed: |
Contributor
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
pushed a commit
that referenced
this pull request
Aug 14, 2020
* master: Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
ordian
pushed a commit
that referenced
this pull request
Aug 17, 2020
…n-race-condition * master: Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563)
ordian
pushed a commit
that referenced
this pull request
Aug 17, 2020
* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#6760 introduces the concept
of an authority discovery
Serviceallowing one to communicate with anauthority discovery
Worker, e.g. to learn theMultiaddrs for a givenAuthorityId.Along with the new
Servicestructure it also alters the authoritydiscovery constructor to return both a worker and a service. This
commit adjusts the callside of the constructor, ignoring the
Servicefor now.
Companion for paritytech/substrate#6760.