Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@cecton
Copy link
Contributor

@cecton cecton commented Aug 13, 2020

No description provided.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 13, 2020
@cecton cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 13, 2020
Copy link
Contributor

@expenses expenses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome!

@seunlanlege
Copy link
Contributor

I guess you don't need to add the env variable to the ci scripts?

@cecton
Copy link
Contributor Author

cecton commented Aug 13, 2020

I guess you don't need to add the env variable to the ci scripts?

Nope! It's using the default value on 600

@cecton
Copy link
Contributor Author

cecton commented Aug 13, 2020

bot merge

@ghost
Copy link

ghost commented Aug 13, 2020

Missing process info; check that the PR belongs to a project column.

@cecton
Copy link
Contributor Author

cecton commented Aug 13, 2020

bot merge PLEASE

@cecton
Copy link
Contributor Author

cecton commented Aug 13, 2020

bot merge

@ghost
Copy link

ghost commented Aug 13, 2020

Missing process info; check that the PR belongs to a project column.

@cecton
Copy link
Contributor Author

cecton commented Aug 13, 2020

bot merge

@ghost
Copy link

ghost commented Aug 13, 2020

Missing approval from the project owner or a minimum of core developers.

@cecton cecton merged commit ae445ef into master Aug 13, 2020
@cecton cecton deleted the cecton-use-async-test-helper branch August 13, 2020 17:01
ordian pushed a commit that referenced this pull request Aug 14, 2020
* master:
  Make parachain validation wasm executor functional (#1574)
  Use async test helper to simplify node testing (#1578)
  guide: validation data refactoring (#1576)
  Remove v0 parachains runtime (#1501)
  [CI] Add github token to generate-release-text (#1581)
  Allow using any polkadot client instead of enum Client (#1575)
  service/src/lib: Update authority discovery construction (#1563)
  Update .editorconfig to what we have in practice (#1545)
  Companion PR for substrate #6672 (#1560)
  pre-redenomination tockenSymbol change (#1561)
ordian pushed a commit that referenced this pull request Aug 17, 2020
…n-race-condition

* master:
  Companion PR for #6862 (#1564)
  implement collation generation subsystem (#1557)
  Add spawn_blocking to SubsystemContext (#1570)
  Companion PR for #6846 (#1568)
  overseer: add a test to ensure all subsystem receive msgs (#1590)
  Implementer's Guide: Flesh out more details for upward messages (#1556)
  Make parachain validation wasm executor functional (#1574)
  Use async test helper to simplify node testing (#1578)
  guide: validation data refactoring (#1576)
  Remove v0 parachains runtime (#1501)
  [CI] Add github token to generate-release-text (#1581)
  Allow using any polkadot client instead of enum Client (#1575)
  service/src/lib: Update authority discovery construction (#1563)
ordian pushed a commit that referenced this pull request Aug 17, 2020
* master:
  overseer: fix build (#1596)
  Companion PR for #6862 (#1564)
  implement collation generation subsystem (#1557)
  Add spawn_blocking to SubsystemContext (#1570)
  Companion PR for #6846 (#1568)
  overseer: add a test to ensure all subsystem receive msgs (#1590)
  Implementer's Guide: Flesh out more details for upward messages (#1556)
  Make parachain validation wasm executor functional (#1574)
  Use async test helper to simplify node testing (#1578)
  guide: validation data refactoring (#1576)
  Remove v0 parachains runtime (#1501)
  [CI] Add github token to generate-release-text (#1581)
  Allow using any polkadot client instead of enum Client (#1575)
  service/src/lib: Update authority discovery construction (#1563)
  Update .editorconfig to what we have in practice (#1545)
  Companion PR for substrate #6672 (#1560)
  pre-redenomination tockenSymbol change (#1561)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants