Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 24, 2021
@rphmeier rphmeier requested a review from pepyakin November 24, 2021 00:07
.await;
match reason {
InvalidCandidate::ExecutionError(_) => {
// We don't raise disputes on execution errors that are likely
Copy link
Contributor

@drahnr drahnr Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print a warn!? This should rarely happen after all right and would mandate some debugging?

@pepyakin
Copy link
Contributor

Subsumed by #4364

@pepyakin pepyakin closed this Nov 24, 2021
@louismerlin louismerlin removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 13, 2022
@rphmeier rphmeier deleted the rh-preparation-timeout-pass branch July 19, 2023 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants