Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

don't initiate disputes for preparation timeout #4357

Closed
rphmeier wants to merge 2 commits into from
Closed

don't initiate disputes for preparation timeout #4357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb644d
don't initiate disputes for preparation timeout
rphmeier Nov 24, 2021
b769fee
fmt
rphmeier Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions node/core/approval-voting/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2310,17 +2310,25 @@ async fn launch_approval(
"Detected invalid candidate as an approval checker.",
);

sender
.send_message(
DisputeCoordinatorMessage::IssueLocalStatement(
session_index,
candidate_hash,
candidate.clone(),
false,
)
.into(),
)
.await;
match reason {
InvalidCandidate::ExecutionError(_) => {
// We don't raise disputes on execution errors that are likely
Copy link
Contributor

@drahnr drahnr Nov 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print a warn!? This should rarely happen after all right and would mandate some debugging?

// spurious.
},
_ => {
sender
.send_message(
DisputeCoordinatorMessage::IssueLocalStatement(
session_index,
candidate_hash,
candidate.clone(),
false,
)
.into(),
)
.await;
},
}

metrics_guard.take().on_approval_invalid();
return ApprovalState::failed(validator_index, candidate_hash)
Expand Down