Add feature for enabling decoding #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ty/fields.rs # src/ty/mod.rs
Merged
1 task
Contributor
not sure there is a need for it, is there? |
Contributor
Author
Just wanted to make absolutely sure before merging and cutting a release. See use-ink/ink#672 |
Robbepop
approved these changes
Feb 4, 2021
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
thanks for the PR! this is definitely a big improvement over the previous design.
Comment on lines
-59
to
-67
| /// Trait for types which can be used to represent strings in type definitions. | ||
| pub trait FormString: | ||
| AsRef<str> + PartialEq + Eq + PartialOrd + Ord + Clone + Debug | ||
| { | ||
| } | ||
|
|
||
| impl FormString for &'static str {} | ||
| impl FormString for String {} | ||
|
|
This was referenced Feb 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for #58, reverting #35
If the
decodeorstdfeature is enabled thenPortableForm::Stringwill be an ownedStringwhich allow decoding. Otherwise it will be a&'static str(this is required for substrate runtimes).todo
ink!