[metadata] update scale-info, remove string parameterization #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Collaborator
Author
|
This is now waiting on a new |
Robbepop
approved these changes
Feb 5, 2021
Collaborator
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
LGTM
Very glad to have this being updated so quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the parameterization of scale-info strings, as originally suggested #663 (comment), and further discussed in paritytech/scale-info#58
Temporarily using branch from paritytech/scale-info#59. Once that is merged and included in a new
scale-inforelease I will update this PR and mark it ready for review.