Upgrade proc-macro-crate to v1 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbepop
reviewed
Mar 11, 2021
| .map(|crate_name| { | ||
| use proc_macro_crate::FoundCrate::*; | ||
| match crate_name { | ||
| Itself => Ident::new("self", Span::call_site()), |
Contributor
There was a problem hiding this comment.
Suggested change
| Itself => Ident::new("self", Span::call_site()), | |
| Itself => Ident::new("crate", Span::call_site()), |
Contributor
There was a problem hiding this comment.
Isn't crate the right keyword then? Actually I wonder if crate as Ident is allowed.
Contributor
Author
There was a problem hiding this comment.
No, it's not, which is why I switched to a token stream in the other PR.
My plan was to merge this change here and then merge it into the other and sort out the Itself-case there.
Robbepop
approved these changes
Mar 11, 2021
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
With #77 (comment) said it is an approval from me.
ascjones
approved these changes
Mar 12, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.