Skip to content

Upgrade proc-macro-crate to v1 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 2 commits into from
Mar 12, 2021
Merged

Upgrade proc-macro-crate to v1 #77

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c76a62d
Upgrade proc-macro-crate to v1
dvdplm Mar 11, 2021
939d1b9
fmt
dvdplm Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fmt
  • Loading branch information
@dvdplm
dvdplm committed Mar 12, 2021
commit 939d1b9f2bb6298b5a44fed9533000c41f359853
2 changes: 1 addition & 1 deletion derive/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ fn crate_name_ident(name: &str) -> Result<Ident> {
use proc_macro_crate::FoundCrate::*;
match crate_name {
Itself => Ident::new("self", Span::call_site()),
Copy link
Contributor

@Robbepop Robbepop Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Itself => Ident::new("self", Span::call_site()),
Itself => Ident::new("crate", Span::call_site()),

Copy link
Contributor

@Robbepop Robbepop Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't crate the right keyword then? Actually I wonder if crate as Ident is allowed.

Copy link
Contributor Author

@dvdplm dvdplm Mar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not, which is why I switched to a token stream in the other PR.

My plan was to merge this change here and then merge it into the other and sort out the Itself-case there.

Name(name) => Ident::new(&name, Span::call_site()),
Name(name) => Ident::new(&name, Span::call_site()),
}
})
.map_err(|e| syn::Error::new(Span::call_site(), &e))
Expand Down