Implement TypeInfo for VecDeque #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robbepop
reviewed
Jun 21, 2021
Contributor
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
I cannot believe we forgot about this. Good catch!
Robbepop
approved these changes
Jun 21, 2021
Contributor
Author
Well, you can thank |
dvdplm
reviewed
Jun 21, 2021
| where | ||
| T: TypeInfo + 'static, | ||
| { | ||
| type Identity = Vec<T>; |
Contributor
There was a problem hiding this comment.
Why not type Identity = [T]; here?
Contributor
Author
There was a problem hiding this comment.
You are right, it should be this in order that [T], Vec<T> and VecDeque<T> all point to the same type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is encoded like a
Vec: https://github.com/paritytech/parity-scale-codec/blob/master/src/codec.rs#L970