Skip to content

Implement TypeInfo for VecDeque #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 1 commit into from
Jun 21, 2021
Merged

Implement TypeInfo for VecDeque #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/impls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ use crate::prelude::{
collections::{
BTreeMap,
BTreeSet,
VecDeque,
},
marker::PhantomData,
string::String,
Expand Down Expand Up @@ -126,6 +127,17 @@ where
}
}

impl<T> TypeInfo for VecDeque<T>
where
T: TypeInfo + 'static,
{
type Identity = Vec<T>;
Copy link
Contributor

@dvdplm dvdplm Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not type Identity = [T]; here?

Copy link
Contributor Author

@ascjones ascjones Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it should be this in order that [T], Vec<T> and VecDeque<T> all point to the same type

Copy link
Contributor Author

@ascjones ascjones Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#100


fn type_info() -> Type {
Self::Identity::type_info()
}
}

impl<T> TypeInfo for Option<T>
where
T: TypeInfo + 'static,
Expand Down
5 changes: 5 additions & 0 deletions src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ fn collections() {
.type_params(tuple_meta_type![String])
.composite(Fields::unnamed().field(|f| f.ty::<[String]>()))
);

assert_type!(
std::collections::VecDeque<String>,
TypeDefSequence::new(meta_type::<String>())
);
}

#[test]
Expand Down