[contracts] Port host functions to Weight V2 and storage deposit limit by agryaznov · Pull Request #13565 · paritytech/substrate

agryaznov · 2023-03-08T17:27:30Z

Port host functions to Weight V2 and storage deposit limit

All host functions dealing with gas now have new version which accounts for the proof_size weight as well.
Added DefaultDepositLimit pallet config parameter, to allow chains set a fallback default value when a caller doesn't set storage_deposit_limit to a call.
New versions of host functions call and instantiate accept storage deposit limit parameter which allow to set the limit for the sub-call. This might be helpful for cross-contract calls. This limit is enforced right after execution returns from the sub-call, and the sub-call is rolled back if the limit has been exhausted during the call.

Drive-by changes

Add max_runtime_mem to schedule limits in order to make its configuration for integrity_test smooth.

add test for nested call deposit limit save: separate deposit limit for nested calls

save: works with test cleaned up debugging outputs

athei · 2023-03-15T14:41:31Z

Tests are failing.

agryaznov · 2023-04-12T18:36:43Z

@pgherveou your comments have been addressed

pgherveou

left a few more nits

frame/contracts/src/storage/meter.rs

frame/contracts/src/lib.rs

pgherveou · 2023-04-13T15:52:06Z

frame/contracts/src/wasm/runtime.rs

 	///
-	/// Equivalent to the newer version [`super::seal1::Api::clear_storage`] with the exception of
-	/// the return type. Still a valid thing to call when not interested in the return value.
+	/// Equivalent to the newer [`seal1`][`super::api_doc::Version1::clear_storage`] version with


maybe we can use Current instead of Version1 to make these links more future proof

frame/contracts/src/benchmarking/mod.rs

Co-authored-by: PG Herveou <pgherveou@gmail.com>

frame/contracts/src/tests.rs

… ag-proof_limit

frame/contracts/src/benchmarking/mod.rs

agryaznov · 2023-04-26T11:11:41Z

bot merge

paritytech-processbot · 2023-04-26T11:11:49Z

Error: Statuses failed for 0dac6f6

agryaznov · 2023-04-26T11:27:06Z

bot merge force

paritytech-cicd-pr · 2023-04-26T11:29:02Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2734781

ggwpez · 2023-04-26T12:00:05Z

There is a failing test from this MR IIUC: deposit_limit_in_nested_instantiate CI log.
in #13945 after i rebased. @agryaznov

#13565) * added [unstable][seal2] call() * updated test to cover new seal_call proof_limit * docs updated * add [seal2][unstable] instantiate() and test * add [seal2][unstable] weight_to_fee() + docs and test * add [seal2][unstable] gas_left() + docs and test * update benchmarks * add DefaultDepositLimit to pallet Config * specify deposit limit for nested call add test for nested call deposit limit save: separate deposit limit for nested calls * specify deposit limit for nested instantiate save: works with test cleaned up debugging outputs * update benchmarks * added missing fixtures * fix benches * pass explicit deposit limit to storage bench * explicit deposit limit for another set_storage bench * add more deposit limit for storage benches * moving to simplified benchmarks * moved to simplified benchmarks * fix seal_weight_to_fee bench * fix seal_instantiate benchmark * doc typo fix * default dl for benchmarking more dl for tests dl for tests to max deposit_limit fix in instantiate bench fix instantiate bench fix instantiate benchmark fix instantiate bench again remove dbg fix seal bench again fixing it still seal_instantiate zero deposit less runs to check if deposit enough try try 2 try 3 try 4 * max_runtime_mem to Schedule limits * add default deposit limit fallback check to test * weight params renaming * fmt * Update frame/contracts/src/benchmarking/mod.rs Co-authored-by: PG Herveou <pgherveou@gmail.com> * prettify inputs in tests * typestate param refactored --------- Co-authored-by: PG Herveou <pgherveou@gmail.com>

paritytech#13565) * added [unstable][seal2] call() * updated test to cover new seal_call proof_limit * docs updated * add [seal2][unstable] instantiate() and test * add [seal2][unstable] weight_to_fee() + docs and test * add [seal2][unstable] gas_left() + docs and test * update benchmarks * add DefaultDepositLimit to pallet Config * specify deposit limit for nested call add test for nested call deposit limit save: separate deposit limit for nested calls * specify deposit limit for nested instantiate save: works with test cleaned up debugging outputs * update benchmarks * added missing fixtures * fix benches * pass explicit deposit limit to storage bench * explicit deposit limit for another set_storage bench * add more deposit limit for storage benches * moving to simplified benchmarks * moved to simplified benchmarks * fix seal_weight_to_fee bench * fix seal_instantiate benchmark * doc typo fix * default dl for benchmarking more dl for tests dl for tests to max deposit_limit fix in instantiate bench fix instantiate bench fix instantiate benchmark fix instantiate bench again remove dbg fix seal bench again fixing it still seal_instantiate zero deposit less runs to check if deposit enough try try 2 try 3 try 4 * max_runtime_mem to Schedule limits * add default deposit limit fallback check to test * weight params renaming * fmt * Update frame/contracts/src/benchmarking/mod.rs Co-authored-by: PG Herveou <pgherveou@gmail.com> * prettify inputs in tests * typestate param refactored --------- Co-authored-by: PG Herveou <pgherveou@gmail.com>

agryaznov added 8 commits March 7, 2023 18:29

added [unstable][seal2] call()

eacb017

updated test to cover new seal_call proof_limit

b3c9265

docs updated

e226add

add [seal2][unstable] instantiate() and test

aba8782

add [seal2][unstable] weight_to_fee() + docs and test

53d8fde

add [seal2][unstable] gas_left() + docs and test

09d1df6

update benchmarks

c644fa1

add DefaultDepositLimit to pallet Config

2cb30c7

agryaznov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 8, 2023

agryaznov self-assigned this Mar 8, 2023

agryaznov force-pushed the ag-proof_limit branch from 2cb30c7 to 3a35000 Compare March 10, 2023 15:29

agryaznov marked this pull request as ready for review March 10, 2023 15:30

agryaznov requested a review from athei as a code owner March 10, 2023 15:30

agryaznov mentioned this pull request Mar 10, 2023

Companion for substrate#13565 paritytech/cumulus#2306

Merged

agryaznov marked this pull request as draft March 10, 2023 15:35

agryaznov added 3 commits March 13, 2023 19:25

specify deposit limit for nested call

a968b29

add test for nested call deposit limit save: separate deposit limit for nested calls

specify deposit limit for nested instantiate

45b48c2

save: works with test cleaned up debugging outputs

Merge branch 'master' into ag-proof_limit

ec58346

agryaznov force-pushed the ag-proof_limit branch from 3a35000 to e8ce9ee Compare March 14, 2023 18:58

agryaznov changed the title ~~[contracts] Port host functions to Weight V2 and set default deposit limit~~ [contracts] Port host functions to Weight V2 and storage deposit limit Mar 15, 2023

agryaznov marked this pull request as ready for review March 15, 2023 08:39

agryaznov added 2 commits March 16, 2023 13:19

update benchmarks

edf1aac

added missing fixtures

2bfb866

agryaznov force-pushed the ag-proof_limit branch from e8ce9ee to 2bfb866 Compare March 16, 2023 11:26

agryaznov added 3 commits March 16, 2023 16:29

fix benches

1ff3f16

pass explicit deposit limit to storage bench

b0f3103

explicit deposit limit for another set_storage bench

3af8712

agryaznov added 4 commits April 12, 2023 18:38

add default deposit limit fallback check to test

af1b353

weight params renaming

04bea78

Merge branch 'master' into ag-proof_limit

c01f166

fmt

50c96da

agryaznov requested a review from pgherveou April 12, 2023 18:37

pgherveou approved these changes Apr 13, 2023

View reviewed changes

Update frame/contracts/src/benchmarking/mod.rs

95c83ea

Co-authored-by: PG Herveou <pgherveou@gmail.com>

pgherveou reviewed Apr 25, 2023

View reviewed changes

frame/contracts/src/tests.rs Outdated Show resolved Hide resolved

agryaznov added 2 commits April 25, 2023 15:34

prettify inputs in tests

22c5794

Merge branch 'ag-proof_limit' of github.com:paritytech/substrate into…

418aa50

… ag-proof_limit

agryaznov requested review from juangirini and xermicus April 25, 2023 16:09

typestate param refactored

0dac6f6

juangirini reviewed Apr 26, 2023

View reviewed changes

frame/contracts/src/benchmarking/mod.rs Show resolved Hide resolved

juangirini approved these changes Apr 26, 2023

View reviewed changes

agryaznov force-pushed the ag-proof_limit branch from d167473 to 0dac6f6 Compare April 26, 2023 11:26

paritytech-processbot bot merged commit af504bc into master Apr 26, 2023

paritytech-processbot bot deleted the ag-proof_limit branch April 26, 2023 11:27

agryaznov mentioned this pull request Apr 26, 2023

contracts: fix failing test #14021

Merged

jasl mentioned this pull request May 10, 2023

Upgrade to Polkadot v0.9.42 Phala-Network/phala-blockchain#1263

Merged

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

CanonicalJP mentioned this pull request Oct 3, 2023

PR#13565 [contracts] Port host functions to Weight V2 and storage deposit limit paritytech/polkadot-sdk#1775

Open

Conversation

agryaznov commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Port host functions to Weight V2 and storage deposit limit

Drive-by changes

Uh oh!

athei commented Mar 15, 2023

Uh oh!

agryaznov commented Apr 12, 2023

Uh oh!

pgherveou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pgherveou Apr 13, 2023

Choose a reason for hiding this comment

Uh oh!

agryaznov Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agryaznov commented Apr 26, 2023

Uh oh!

paritytech-processbot bot commented Apr 26, 2023

Uh oh!

agryaznov commented Apr 26, 2023

Uh oh!

paritytech-cicd-pr commented Apr 26, 2023

Uh oh!

ggwpez commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

agryaznov commented Mar 8, 2023 •

edited

Loading

ggwpez commented Apr 26, 2023 •

edited

Loading