-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Staking: Minor typo fix: of -> or #2963
Conversation
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
1 similar comment
|
It looks like @JoshOrndorff signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
| //! Almost any interaction with the staking module requires a process of _**bonding**_ (also known as | ||
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some of all of the | ||
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the | ||
| //! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| //! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues | |
| //! funds that become frozen in place as part of the staking process, is paired with an active _controller_ account which issues |
| //! | ||
| //! Almost any interaction with the staking module requires a process of _**bonding**_ (also known as | ||
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some of all of the | ||
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the | |
| //! being a _staker_). To become *bonded* a fund-holding account known as the _stash_ account, which holds some or all of the |
joepetrowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well make formatting consistent while here.
|
CI fails with
Do we need to change |
Nope, |
| impl_name: create_runtime_str!("node-template"), | ||
| authoring_version: 3, | ||
| spec_version: 4, | ||
| impl_version: 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert.
node/runtime/src/lib.rs
Outdated
| authoring_version: 10, | ||
| spec_version: 60, | ||
| impl_version: 62, | ||
| impl_version: 63, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
This reverts commit 9439654.
This is a straight forward typo fix.
PR is against v1.0 because this typo was already fixed on master as part of a much larger overhaul (#2802)