Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@JoshOrndorff
Copy link
Contributor

This is a straight forward typo fix.

PR is against v1.0 because this typo was already fixed on master as part of a much larger overhaul (#2802)

@parity-cla-bot
Copy link

It looks like @JoshOrndorff signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

1 similar comment
@parity-cla-bot
Copy link

It looks like @JoshOrndorff signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

//! Almost any interaction with the staking module requires a process of _**bonding**_ (also known as
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some of all of the
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the
//! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues
//! funds that become frozen in place as part of the staking process, is paired with an active _controller_ account which issues

//!
//! Almost any interaction with the staking module requires a process of _**bonding**_ (also known as
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some of all of the
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash_ account, which holds some or all of the

Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well make formatting consistent while here.

@JoshOrndorff
Copy link
Contributor Author

CI fails with

wasm source files changed but not the spec/impl version and the runtime
binary blob. If changes made do not alter logic, just bump 'impl_version'.
If they do change logic, bump 'spec_version' and rebuild wasm.

Do we need to change impl_version for comment changes? I'll give it a try.

@joepetrowski
Copy link
Contributor

CI fails with

wasm source files changed but not the spec/impl version and the runtime
binary blob. If changes made do not alter logic, just bump 'impl_version'.
If they do change logic, bump 'spec_version' and rebuild wasm.

Do we need to change impl_version for comment changes? I'll give it a try.

Nope, impl should stay the same unless code changes.

impl_name: create_runtime_str!("node-template"),
authoring_version: 3,
spec_version: 4,
impl_version: 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert.

authoring_version: 10,
spec_version: 60,
impl_version: 62,
impl_version: 63,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A4-gotissues labels Jun 28, 2019
@gavofyork gavofyork merged commit ea3b770 into v1.0 Jun 28, 2019
@gavofyork gavofyork deleted the joshy-typo1 branch June 28, 2019 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants