Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Staking: Minor typo fix: of -> or #2963

Merged
gavofyork merged 3 commits into from
Jun 28, 2019
Merged

Staking: Minor typo fix: of -> or #2963

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceb7ae5
Staking: Minor typo fix: of -> or
JoshOrndorff Jun 26, 2019
9439654
Bump impl version (only rustdoc changed).
JoshOrndorff Jun 27, 2019
6afb860
Revert "Bump impl version (only rustdoc changed)."
JoshOrndorff Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node-template/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
impl_name: create_runtime_str!("node-template"),
authoring_version: 3,
spec_version: 4,
impl_version: 4,
Copy link
Member

@bkchr bkchr Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert.

impl_version: 5,
apis: RUNTIME_API_VERSIONS,
};

Expand Down
2 changes: 1 addition & 1 deletion node/runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
impl_name: create_runtime_str!("substrate-node"),
authoring_version: 10,
spec_version: 60,
impl_version: 62,
impl_version: 63,
Copy link
Member

@bkchr bkchr Jun 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

apis: RUNTIME_API_VERSIONS,
};

Expand Down
2 changes: 1 addition & 1 deletion srml/staking/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
//! #### Staking
//!
//! Almost any interaction with the staking module requires a process of _**bonding**_ (also known as
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some of all of the
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the
Copy link
Contributor

@joepetrowski joepetrowski Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash account_, which holds some or all of the
//! being a _staker_). To become *bonded* a fund-holding account known as the _stash_ account, which holds some or all of the

//! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues
Copy link
Contributor

@joepetrowski joepetrowski Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//! funds that become frozen in place as part of the staking process, is paired with an active **controller** account which issues
//! funds that become frozen in place as part of the staking process, is paired with an active _controller_ account which issues

//! instructions on how they shall be used.
//!
Expand Down