This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Make ping unidirectional #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
approved these changes
Jul 30, 2018
rphmeier
added
A8-looksgood
and removed
A0-please_review
dvdplm
added a commit
that referenced
this pull request
Aug 1, 2018
* master: Collator for the "adder" (formerly basic-add) parachain and various small fixes (#438) Storage changes subscription (#464) Wasm execution optimizations (#466) Fix the --key generation (#475) Fix typo in service.rs (#472) Fix session phase in early-exit (#453) Make ping unidirectional (#458) Update README.adoc
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
This replicates changes to `Environment`/`Proposer` that are used internally at Cumulus.
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* generate mock trustee addr * add some comment
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
Remove farmer workarounds for node's RPC
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
…ritytech#458) * Distinct handling for N fields + 1 hasher vs N fields + N hashers * tweak comment * cargo fmt * fix typo * Add a few storage specific tests * clippy fixes * cargo fmt * Add a test to specifically address this fix * comment typo * Address niggles * slgihtly nicer iter code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now once we open a substream to a remote for pinging, this substream is used for both pinging the remote and receiving ping from the remote.
However it looks like the libp2p ping protocol is actually unidirectional. In other words, if A wants to send a ping to B, it needs to have opened a substream to B and cannot use a substream that was opened by B.
This change is backwards compatible and should fix the interop with polkadot-js.