Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@arkpar
Copy link
Member

@arkpar arkpar commented Jul 31, 2018

Since wasm interpreter now allocates memory lazily it is safe to set page limit to a high value without performance loss.

@arkpar arkpar added the A0-please_review Pull request needs code review. label Jul 31, 2018
enum Compatibility {
InvalidVersion(WasmModule),
IsCompatible(RuntimeVersion),
IsCompatible(RuntimeVersion, WasmModule),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If natve+wasm execution is requested this should still cache the module. Wasm execution will be performed even if the version is compatible.

@gavofyork gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 1, 2018
@gavofyork gavofyork merged commit fc1ae1c into master Aug 1, 2018
@gavofyork gavofyork deleted the a-cache-module branch August 1, 2018 11:29
dvdplm added a commit that referenced this pull request Aug 1, 2018
* master:
  Wasm execution optimizations (#466)
  Fix the --key generation (#475)
  Fix typo in service.rs (#472)
  Fix session phase in early-exit (#453)
dvdplm added a commit that referenced this pull request Aug 1, 2018
* master:
  Collator for the "adder" (formerly basic-add) parachain and various small fixes (#438)
  Storage changes subscription (#464)
  Wasm execution optimizations (#466)
  Fix the --key generation (#475)
  Fix typo in service.rs (#472)
  Fix session phase in early-exit (#453)
  Make ping unidirectional (#458)
  Update README.adoc
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* change upstream and branch

* Fix build

* remove doc renamings

* Fix tests

* .

* Revert changing fork and branch

* Update Cargo.toml

* Update parachains.rs
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants